1669247 - update circleci to auth with dockerhub (socorro)

Status: RESOLVED FIXED

(Socorro :: General, task, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

+++ This bug was initially created as a clone of Bug #1669245 +++

CircleCI sent this:

On November 1st, Docker Hub will begin limiting anonymous image pulls. We want to make sure you know how you might be impacted and what you can do to avoid interruptions to your workflow.

It links to these docs:

https://circleci.com/docs/2.0/private-images/

We need to fix the circleci file to authenticate with dockerhub in the first step so all subsequent docker hub pulls don't get rate-limited.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5609: bug 1669247: add dockerhub auth

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5609: "bug 1669247: add dockerhub auth" in a36c4e6.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I made these changes, per Brian's instructions.

https://github.com/mozilla-services/Dockerflow/blob/8aa28daed38aa55de42e9248e1e0ac4bac33b0c8/.circleci/config.yml#L12-L14

https://github.com/mozilla-services/Dockerflow/blob/8aa28daed38aa55de42e9248e1e0ac4bac33b0c8/.circleci/config.yml#L31-L38

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5610: bug 1669247: conform to Dockerflow standards

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5610: "bug 1669247: conform to Dockerflow standards" in 1a60a5e.

I'll watch this through CircleCI and then the deploy and make sure it goes well.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

The deploy didn't kick off because we had stage deploys gated on the structure of the tag. Brian fixed that and I re-ran the CircleCI job which pushed another latest tag and Socorro deployed to stage.

We think we're good here.

Next step is to see how it deploys to prod.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5611: bug 1669247: fix local image name for prod deploys

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5611: "bug 1669247: fix local image name for prod deploys" in 63a1ebb.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

I pushed this to prod just now in bug #1676430.