1669350 - Profiler button dropdown arrow does not work on RTL

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Greg Tatum [:gregtatum]]

Steps to reproduce:

• In about:config change the pref intl.l10n.pseudo to bidi (docs)
• Go to profiler.firefox.com
• Enable the profiler menu button
• Click the arrow

Expected Behavior:

• The arrow panel opens

Actual behavior:

• The profiler button is activated.

The only way I was able to open it was to use the keyboard to focus the button, and hit the down arrow.

Click handling code in question: https://searchfox.org/mozilla-central/rev/35245411b9e8a911fe3f5adb0632c3394f8b4ccb/devtools/client/performance-new/popup/menu-button.jsm.js#35

Comment 1

[Florian Quèze [:florian]]

The problem is that at https://searchfox.org/mozilla-central/rev/35245411b9e8a911fe3f5adb0632c3394f8b4ccb/devtools/client/performance-new/popup/menu-button.jsm.js#337 we use the RTL_UI getter from browser.js, implemented at https://searchfox.org/mozilla-central/rev/1a973762afcbc5066f73f1508b0c846872fe3952/browser/base/content/browser.js#291-293 which caches the first value it sees. There's bug 1539349 covering this.

If in your steps to reproduce you open a new browser window after changing the pref value in about:config, the bug doesn't reproduce anymore.

If this gets in the way of automated tests, we can use Services.locale.isAppLocaleRTL directly instead of win.RTL_UI. Otherwise I think we can just close this as duplicate or worksforme.

Comment 2

[Julien Wajsberg [:julienw]]

I think this gets in the way of manual tests too, not just automated tests. We should use Services.locale.isAppLocaleRTL directly, thanks for the pointer!

Comment 3

[Markus Stange [:mstange]]

This was fixed by bug 1650835.