1669370 - Purge the worst/most obvious cases of corrupt/invalid printing prefs

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement, P1)

Description

[Jonathan Watt [:jwatt]]

We've had a series of bug reports recently about corrupted/invalid print settings being saved to prefs. Bad printing prefs have the potential to not only make prints go bad once, but also to completely break printing for users unless they clear their printing prefs manually. Since most users will have no clue how to do this (and we wouldn't want potentially large numbers of Release users to get into that position anyway!), I'm very concerned about issues like this appearing in Release.

I'd like to add some mitigations to reject the worst/most obvious cases of corrupt/invalid printing prefs at the point we read them, and thereby purge those values. However, since my immediate concern is to get some mitigations uplifted to Beta I'll only be making low risk mitigations rather than aggressive ones for now.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1669370. Purge the worst/most obvious cases of corrupt/invalid printing prefs. r=bobowen,emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa1645112573
Purge the worst/most obvious cases of corrupt/invalid printing prefs. r=emilio

Comment 3

[Jonathan Watt [:jwatt]]

Comment on attachment 9179758 [details]
Bug 1669370. Purge the worst/most obvious cases of corrupt/invalid printing prefs. r=bobowen,emilio

Beta/Release Uplift Approval Request

• User impact if declined: Please see comment 0. We already seem to have the risk that previous changes have
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is very conservative in only purging the most obviously broken pref values, but will purge at least some of the cases of bad prefs that we've been getting reports of on Nightly and Beta and hopefully reduce the chances of those even happening on Release.
• String changes made/needed:

Comment 4

[Julien Cristau [:jcristau]]

Comment on attachment 9179758 [details]
Bug 1669370. Purge the worst/most obvious cases of corrupt/invalid printing prefs. r=bobowen,emilio

approved for 82.0b8

Comment 5

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c1a76e1908d1

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/aa1645112573