1669468 - Refactor heap size triggers a little

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Jon Coppeard (:jonco)]

While looking into improving behaviour when the GC heap is full I refactored some of the heap size triggers.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1669468 - Remove separate GC reasons incremental/non-incremental trigger kinds and reasons.

This simplifies the threshold checks and the decision to make a collection
non-incremental ultimately happens in GCRuntime::budgetIncrementalGC anyway. We
still have telemetry for incremental/non-incremental collections and
non-incremental reason.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1669468 - Rename methods that check heap sizes to be more readable r?sfink

Also removed the call in js::intl::AddICUCellMemory since AddCellMemory calls this already.

Depends on D92592

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1669468 - Factor out code to update zone heap size thresholds into separate methods r?sfink

Depends on D92593

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/181a90c3250e
Remove separate GC reasons incremental/non-incremental trigger kinds and reasons. r=sfink
https://hg.mozilla.org/integration/autoland/rev/4610635ff004
Rename methods that check heap sizes to be more readable r=sfink
https://hg.mozilla.org/integration/autoland/rev/2c76a244a4d9
Factor out code to update zone heap size thresholds into separate methods r=sfink

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/181a90c3250e
https://hg.mozilla.org/mozilla-central/rev/4610635ff004
https://hg.mozilla.org/mozilla-central/rev/2c76a244a4d9