1669506 - The “https://wiki.mozilla.org/Project_Fission” page is wrongly opened if the “Fission” doorhanger is dismissed using the “Esc” key

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: WronglyBehavior_ESCkey.gif

[Affected versions]:

• Firefox Nightly 83.0a1 (Build ID: 20201006041051)

[Affected Platforms]:

• Windows 10 x64
• Windows 7 x64
• Mac 10.15

[Prerequisites]:

• Have the latest Firefox Nightly browser installed.
• Have a new Firefox profile.
• Have the user.js for the “fission-enabled” branch downloaded to your PC.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to the "about:support" page and open the profile folder.
3. Paste the user.js file from prerequisites and restart the browser.
4. Restart the browser for the second time and navigate to any website (e.g. https://www.wikipedia.org/).
5. Press the “Esc” key after the Fission experiment doorhanger is displayed.
6. Observe the behavior.

[Expected result]:

• The Fission experiment doorhanger is closed and nothing else happens.

[Actual result]:

• The Fission experiment doorhanger is closed and the “https://wiki.mozilla.org/Project_Fission” page is opened in a new tab.

[Notes]:

• Attached a screen recording with the issue.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

andreio, does the https://github.com/mozilla/messaging-system-inflight-assets/pull/156 somehow specify any kind of action executed when we press "Esc"?

Comment 2

[Andrei Oprea [:andreio]]

I think this happens because the OPEN_URL action is defined on the secondary button (where "normally" primary means an action and secondary means dismiss. secondary for the PopupNotification code is probably associated with the Esc key to dismiss so it get accidentally triggered.
We could switch them around but if the current way it looks is OK, I don't think it's worth doing.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

I think going to the Wiki will surprise people who navigate with keyboard and press "Esc".

I'll open a PR with the change later today.

Comment 4

[Neha Kochar [:neha]]

David, please close this when the PR change lands. And please add a link to the PR here for posterity.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

https://github.com/mozilla/messaging-system-inflight-assets/pull/161 has landed!

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 83.0a1 (Build ID: 20201013094053) on Windows 10 x64, and Mac 10.15.6.

• The Fission doorhanger is dismissed when pressing the “Esc” key.