1669526 - Don't show the heuristic result for partially typed token aliases and show all the matching token aliases

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Marco Bonardo [:mak]]

UX proposed these changes.

When typing part of a token alias:

1. the token alias will be autofilled, but we won't show an heuristic result
2. show all the token aliases matching the partially types alias, the autofilled one should be the first one

When pressing Enter: the autofilled token should change to search mode
When pressing down or tab: enter search mode for the selected engine (the first down/tab will in practice act the same as pressing Enter)

The idea is that Down, Tab and Enter will all allow to fill the proposed engine, then you can still tab or down to the next ones.

Comment 1

[Harry Twyford]

Attachment: Bug 1669526 - Don't show the heuristic result for partially typed token aliases and show all the matching token aliases. r?adw!

The heavily nested structure of UrlbarInput.setValueFromResult made it difficult to handle a result that was both a keywordoffer and autofilled. I took this opportunity to refactor setValueFromResult to be flatter. I think it's a bit easier to read now.

Comment 2

[Harry Twyford]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b69d7f035246bfcab34af46af9b415cc401b130

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a8ad0e28878
Don't show the heuristic result for partially typed token aliases and show all the matching token aliases. r=adw

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6a8ad0e28878