1669538 - Add new nsIXULRuntime enum for Fission enablement/disablement status/reason

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P2)

Description

[Kris Maglione [:kmag]]

This should replace the current E10s decision status since the two are strictly dependent.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1669538: Expose reason for Fission enablement decision in nsIXULRuntime. r=nika

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5f507cc51ab
Expose reason for Fission enablement decision in nsIXULRuntime. r=nika

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for build bustage on nsAppRunner.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/c9b027976b106afe4017cbdf7caf9c23842cb156

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=VzD96owYSMmjs9mw7q3S0A.0&revision=a5f507cc51abc6cdef87ee1d47db230460b8fed5

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317946450&repo=autoland&lineNumber=27921

[task 2020-10-07T21:46:37.111Z] 21:46:37 ERROR - /builds/worker/checkouts/gecko/toolkit/xre/nsAppRunner.cpp:1051:39: error: comparison of different enumeration types ('nsIXULRuntime::ExperimentStatus' and 'nsIXULRuntime::FissionDecisionStatus') [-Werror,-Wenum-compare]
[task 2020-10-07T21:46:37.111Z] 21:46:37 INFO - MOZ_ASSERT(gFissionExperimentStatus != eFissionStatusUnknown);
[task 2020-10-07T21:46:37.111Z] 21:46:37 INFO - ~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~
[task 2020-10-07T21:46:37.111Z] 21:46:37 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:414:24: note: expanded from macro 'MOZ_ASSERT'
[task 2020-10-07T21:46:37.112Z] 21:46:37 INFO - ("MOZ_ASSERT", VA_ARGS))
[task 2020-10-07T21:46:37.113Z] 21:46:37 INFO - ^~~~~~~~~~~
[task 2020-10-07T21:46:37.113Z] 21:46:37 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:404:33: note: expanded from macro 'MOZ_ASSERT_GLUE'
[task 2020-10-07T21:46:37.113Z] 21:46:37 INFO - #define MOZ_ASSERT_GLUE(a, b) a b
[task 2020-10-07T21:46:37.113Z] 21:46:37 INFO - ^
[task 2020-10-07T21:46:37.113Z] 21:46:37 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:385:40: note: expanded from macro 'MOZ_ASSERT_HELPER1'
[task 2020-10-07T21:46:37.113Z] 21:46:37 INFO - MOZ_VALIDATE_ASSERT_CONDITION_TYPE(expr);
[task 2020-10-07T21:46:37.113Z] 21:46:37 INFO - ^~~~
[task 2020-10-07T21:46:37.113Z] 21:46:37 INFO - /builds/worker/workspace/obj-build/dist/include/mozilla/Assertions.h:367:58: note: expanded from macro 'MOZ_VALIDATE_ASSERT_CONDITION_TYPE'
[task 2020-10-07T21:46:37.114Z] 21:46:37 INFO - mozilla::detail::AssertionConditionType<decltype(x)>::isValid,
[task 2020-10-07T21:46:37.114Z] 21:46:37 INFO - ^

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1669538: Fix assertion that wound up in the wrong place.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50faa64a4925
Expose reason for Fission enablement decision in nsIXULRuntime. r=nika

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/50faa64a4925