1669573 - Simplify nsDateFormatSelector enum

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Dan Minor [:dminor]]

From Bug 1426907 comment 158, some of the values for nsDateFormatSelector are no longer used or not appropriate. This bug will track removing the unused values and adding a new DateTimeFormat::GetDisplayName method for kDateFormatMonthLong and kDateFormatWeekday. This cleanup will help with Bug 1426907 and hopefully simplify switching over to the Rust DateTime implementation in the future.

Comment 1

[Dan Minor [:dminor]]

Try run here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6c97ffdc0ed027b7b2f7f51a6e3b4e66d93f167

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1669573 - Add DataTimeFormat::GetCalendarSymbol; r=zbraniecki!

This adds a method to get the display name for a month or a weekday in long or
short form. We'll add more fields and styles in the future, the current patch
provides enough functionality to replace the selectors for kDateFormatMonthLong
and kDateFormatWeekday, which are currently used to retrieve display names by
calling FormatPRExplodedTime.

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1669573 - Call DeleteCache when changing locale in TestDateTimeFormat; r=zbraniecki!

The formatters in mFormatCache are only valid for the locale in which they were
created. Currently the tests change mLocale directly but leave the cache in
place which can lead to incorrect test results depending upon which tests are
executed. This is not a problem outside of the tests because mLocale is normally
only set once during the call to Initialize() which will not change the current
locale once it is set.

Depends on D93008

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1669573 - Replace kDateFormatMonthLong/kDateFormatWeekday with GetCalendarSymbol; r=zbraniecki!

Depends on D93009

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1669573 - Rename kTimeFormatSeconds and kTimeFormatNoSeconds; r=zbraniecki!

This renames kTimeFormatSeconds to kTimeFormatLong and kTimeFormatNoSeconds to
kTimeFormatShort. This is consistent with the naming used for date format
selectors.

Depends on D93010

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1669573 - Add DataTimeFormat::FormatDateTime; r=zbraniecki!

This adds a FormatDateTime method that takes a skeleton as an argument and
returns the localized date and time according to the skeleton. In the future,
we'll add an overload that allows taking an DateTimeOptions property bag, but
for now, this will provide enough functionality to allow us to remove the
kDateFormatYearMonth and kDateFormatYearMonthLong selectors as well as the code
for handling skeletons from FormatPRExplodedTime.

Depends on D93011

Comment 7

[Dan Minor [:dminor]]

Attachment: Bug 1669573 - Replace kDateFormatYearMonth/kDateFormatYearMonthLong with FormatDateTime; r=zbraniecki!

Depends on D93012

Comment 8

[Dan Minor [:dminor]]

Updated try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=05756e116fdf3c7c3105c11c59c12519cbfb6719

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9230f50a236e
Add DataTimeFormat::GetCalendarSymbol; r=zbraniecki
https://hg.mozilla.org/integration/autoland/rev/2d91e316f450
Call DeleteCache when changing locale in TestDateTimeFormat; r=zbraniecki
https://hg.mozilla.org/integration/autoland/rev/f2800056f310
Replace kDateFormatMonthLong/kDateFormatWeekday with GetCalendarSymbol; r=zbraniecki
https://hg.mozilla.org/integration/autoland/rev/0fac34686721
Rename kTimeFormatSeconds and kTimeFormatNoSeconds; r=zbraniecki
https://hg.mozilla.org/integration/autoland/rev/9e44a2c80df2
Add DataTimeFormat::FormatDateTime; r=zbraniecki
https://hg.mozilla.org/integration/autoland/rev/0f1220aeaf17
Replace kDateFormatYearMonth/kDateFormatYearMonthLong with FormatDateTime; r=zbraniecki

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9230f50a236e
https://hg.mozilla.org/mozilla-central/rev/2d91e316f450
https://hg.mozilla.org/mozilla-central/rev/f2800056f310
https://hg.mozilla.org/mozilla-central/rev/0fac34686721
https://hg.mozilla.org/mozilla-central/rev/9e44a2c80df2
https://hg.mozilla.org/mozilla-central/rev/0f1220aeaf17

Comment 11

[José M. Muñoz]

Just for the record: kDateFormatWeekday was used in Thunderbird and had especially been restored in bug 1329841 after being removed for the first time when switching to ICU earlier on. Now Thunderbird filed bug 1672548 to restore that formatting.