1669574 - [wpt-sync] Sync PR 26012 - Handle transferred channels in ConvolverNode

Status: RESOLVED FIXED

(Core :: Web Audio, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 26012 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26012
Details from upstream follow.

b'Raymond Toy <[e-mail]>' wrote:

Handle transferred channels in ConvolverNode

If any channel of an AudioBuffer is transferred (detached) when given
to a ConvolverNode, we treat it as if no buffer were given[1] and reset
the internal reverb to null so that the output is all zeroes.

[1] The spec on acquiring the contents of an AudioBuffer says if any
buffer is acquired, treat it as if all are.

Bug: 1134930
Change-Id: I413b9acf38bdf2efe2a466968ae9074df6956fd5

Reviewed-on: https://chromium-review.googlesource.com/2450350
WPT-Export-Revision: 691e4dbc74676461dc2bbdaa9a6a3adeffed0bf4

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=69a4d4c620d0ebbb44dd35d3b5e63b822687e954

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
PASS : 8

Chrome

CRASH: 1

Safari

ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3594e30280b
[wpt PR 26012] - Handle transferred channels in ConvolverNode, a=testonly

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c3594e30280b