1669691 - AppMenu jumpy when it grows/shrinks

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, task)

Description

[Richard Marti (:Paenglab)]

When the AppMenu grows or shrinks it jumps to the new size and doesn't transform smoothly. This comes because styles from bug 1437512 didn't land in TB.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1669691-port-missing-panelmultiview-styles.patch

To test it, try following:

• select a message
• open the AppMenu and go to View - Text Encoding
• look how the AppMenu grows

With latest m-c build you should apply bug 1669686 to not have unrelated issues.

Comment 2

[Richard Marti (:Paenglab)]

Ahh, forgot this is a port of https://hg.mozilla.org/mozilla-central/rev/b2acd3d12275 browser.css part.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9180146 [details] [diff] [review]
1669691-port-missing-panelmultiview-styles.patch

Review of attachment 9180146 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Thanks for taking care of this.

Is the commit message correct? Shouldn't be something like "Port bug 1437512: Implement the panelmultiview CSS transition".
I think that's more accurate for us than reusing the title of the ported bug since we're porting only the CSS portion.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1669691-port-missing-panelmultiview-styles.patch

Updated the commit message.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e3da5d782272
Port bug 1437512: Implement the panelmultiview CSS transition. r=aleca DONTBUILD

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9180209 [details] [diff] [review]
1669691-port-missing-panelmultiview-styles.patch

[Approval Request Comment]
User impact if declined: not smooth growing/shrinking AppMenu
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9180209 [details] [diff] [review]
1669691-port-missing-panelmultiview-styles.patch

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/cb8bd209b76f

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9180209 [details] [diff] [review]
1669691-port-missing-panelmultiview-styles.patch

[Triage Comment]
Approved for esr78

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/1893ab3245d2