Closed Bug 1669691 Opened 8 months ago Closed 8 months ago

AppMenu jumpy when it grows/shrinks

Categories

(Thunderbird :: Mail Window Front End, task)

Tracking

(thunderbird_esr78 fixed, thunderbird82 fixed)

RESOLVED FIXED
83 Branch
Tracking Status
thunderbird_esr78 --- fixed
thunderbird82 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

When the AppMenu grows or shrinks it jumps to the new size and doesn't transform smoothly. This comes because styles from bug 1437512 didn't land in TB.

To test it, try following:

  • select a message
  • open the AppMenu and go to View - Text Encoding
  • look how the AppMenu grows

With latest m-c build you should apply bug 1669686 to not have unrelated issues.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9180146 - Flags: review?(alessandro)

Ahh, forgot this is a port of https://hg.mozilla.org/mozilla-central/rev/b2acd3d12275 browser.css part.

Comment on attachment 9180146 [details] [diff] [review]
1669691-port-missing-panelmultiview-styles.patch

Review of attachment 9180146 [details] [diff] [review]:
-----------------------------------------------------------------

Great! Thanks for taking care of this.

Is the commit message correct? Shouldn't be something like "Port bug 1437512: Implement the panelmultiview CSS transition".
I think that's more accurate for us than reusing the title of the ported bug since we're porting only the CSS portion.
Attachment #9180146 - Flags: review?(alessandro) → review+

Updated the commit message.

Attachment #9180146 - Attachment is obsolete: true
Attachment #9180209 - Flags: review+
Target Milestone: --- → 83 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/e3da5d782272
Port bug 1437512: Implement the panelmultiview CSS transition. r=aleca DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED

Comment on attachment 9180209 [details] [diff] [review]
1669691-port-missing-panelmultiview-styles.patch

[Approval Request Comment]
User impact if declined: not smooth growing/shrinking AppMenu
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9180209 - Flags: approval-comm-esr78?
Attachment #9180209 - Flags: approval-comm-beta?

Comment on attachment 9180209 [details] [diff] [review]
1669691-port-missing-panelmultiview-styles.patch

[Triage Comment]
Approved for beta

Attachment #9180209 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9180209 [details] [diff] [review]
1669691-port-missing-panelmultiview-styles.patch

[Triage Comment]
Approved for esr78

Attachment #9180209 - Flags: approval-comm-esr78? → approval-comm-esr78+
You need to log in before you can comment on or make changes to this bug.