Intermittent comm/calendar/test/browser/timezones/browser_timezones.js | Test timed out -
Categories
(Calendar :: General, defect, P5)
Tracking
(thunderbird_esr78 wontfix, thunderbird_esr91 wontfix)
People
(Reporter: intermittent-bug-filer, Unassigned)
Details
(Keywords: intermittent-failure, Whiteboard: [fixed by bug 1629492])
Attachments
(1 file, 2 obsolete files)
7.13 KB,
patch
|
aleca
:
review-
|
Details | Diff | Splinter Review |
Filed by: mkmelin+mozilla [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=317885320&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/DBsWuX7LQaetM1JKZXDUyg/runs/0/artifacts/public/logs/live_backing.log
Bug 1649295 improved stuff a bunch, but there are still occasional intermittence.```
Updated•4 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•3 years ago
|
Comment 9•3 years ago
|
||
I'm working on this.
I can reproduce this locally, but only randomly, like 1 time out of 5.
I suspect this method is the culprit which fails to click on the timezone link: https://searchfox.org/comm-central/rev/477376239c7add0cb7581d788e2cd79a1a4360b2/calendar/test/modules/ItemEditingHelpers.jsm#204
Let's see if I can figure it out.
Comment 10•3 years ago
|
||
With this it doesn't fail locally anymore.
Let's see if we have a green try-run: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=7dc50cbbf107699b44c645bff9a5a39c0221770c
Comment 11•3 years ago
|
||
Comment on attachment 9198556 [details] [diff] [review]
1669705-test.diff
Yoink. I can see why this fails now. Doing something in dialogWindow
and expecting it to happen immediately in iframeWindow
wasn't the best idea. Thanks for investigating.
Comment 12•3 years ago
|
||
Comment on attachment 9198556 [details] [diff] [review]
1669705-test.diff
Unfortunately this is still failing.
Comment 13•3 years ago
|
||
I'm kinda lost with this intermittent failure.
I was able to reproduce it locally and by looking at it when the test fails, it seems that the issue is localized here: https://searchfox.org/comm-central/rev/5e2a193b811cd20e275bb8216e20799b24141c25/calendar/test/modules/ItemEditingHelpers.jsm#591-592
It seems that the click happens before the label is visible, therefore the menupopup never opens and the test can't continue, resulting in the failure detecting a leftover dialog still present.
I updated all the promises to avoid this issue but it still happens, as usual exclusively on macos.
Any suggestions?
Comment hidden (Intermittent Failures Robot) |
Comment 15•3 years ago
|
||
Comment on attachment 9198838 [details] [diff] [review] 1669705-test.diff Review of attachment 9198838 [details] [diff] [review]: ----------------------------------------------------------------- All look good to me. THe only think I could possibly think of is the disable-on-readonly stuff. Maybe assert the menu is not disabled? ::: calendar/test/modules/ItemEditingHelpers.jsm @@ +458,2 @@ > synthesizeMouseAtCenter(menulist, {}, iframeWindow); > + await popupPromise; At least personally I like naming them after the event, like popupshown, as elsewhere in this patch
Comment 16•3 years ago
|
||
This seems to be doing the trick.
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=feb3e2a2938978f03d2eaae2b017ea0fce7218b9
I removed the disable on readonly attribute and moved the creation of the waitForCondition
promise waiting for the visible timezone label outside the is_visible()
condition.
Comment 17•3 years ago
|
||
Comment on attachment 9199454 [details] [diff] [review] 1669705-test.diff Review of attachment 9199454 [details] [diff] [review]: ----------------------------------------------------------------- ::: calendar/test/modules/ItemEditingHelpers.jsm @@ +587,5 @@ > let iframeDocument = iframeWindow.document; > > let menuitem = dialogDocument.getElementById("options-timezones-menuitem"); > let label = iframeDocument.getElementById("timezone-starttime"); > + label.removeAttribute("disable-on-readonly"); It's a bit of cheating. It could be disabled in the real world and we wouldn't notice. Maybe we should wait for this attribute to go away? There's waitForAttributeRemoval
Comment 18•3 years ago
|
||
Maybe we should wait for this attribute to go away? There's waitForAttributeRemoval
Uh, nice! I'll give it a try.
Comment 19•3 years ago
|
||
Comment on attachment 9199454 [details] [diff] [review]
1669705-test.diff
This causes another set of failures.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 25•3 years ago
|
||
The test helpers used in these tests have been changed since disabling the tests, and it look like the suggested changes have been implemented in these test helpers. Would it be worthwhile to enabled the test again, or otherwise try if the intermittent failure could still be observed?
Comment 26•3 years ago
|
||
The test got re-enabled with fix from bug 1629492.
Updated•3 years ago
|
Updated•3 years ago
|
Description
•