Closed
Bug 1669815
Opened 4 years ago
Closed 1 year ago
Remove now-useless "aInRange" outparam from nsPrintJob::PrintPage (and simplify nsPagePrintTimer::StartTimer() which consumes it?)
Categories
(Core :: Printing: Output, task)
Core
Printing: Output
Tracking
()
RESOLVED
FIXED
121 Branch
| Tracking | Status | |
|---|---|---|
| firefox121 | --- | fixed |
People
(Reporter: dholbert, Assigned: jwatt)
References
Details
(Whiteboard: [print2020][old-ui-])
Attachments
(1 file)
TYLin noticed in https://phabricator.services.mozilla.com/D92660#inline-525188 that the aInRange outparam for nsPrintJob::PrintPage is now becoming useless, now that print-ranges are handled earlier on (and every printed sheet is trivially "in range").
We should remove this outparam, and look into simplifying the code that consumed it (it seemed to be used for print-timer-duration calculations in
nsPagePrintTimer::Run() via nsPagePrintTimer::StartTimer()).
|
Assignee | |
Updated•4 years ago
|
Whiteboard: [print2020_v84][old-ui-]
|
|
Assignee | |
Updated•4 years ago
|
Whiteboard: [print2020_v84][old-ui-] → [print2020_v85][old-ui-]
|
|
Assignee | |
Updated•4 years ago
|
Whiteboard: [print2020_v85][old-ui-] → [print2020_v87][old-ui-]
|
|
Assignee | |
Updated•4 years ago
|
Whiteboard: [print2020_v87][old-ui-] → [print2020][old-ui-]
|
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → jwatt
Status: NEW → ASSIGNED
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/22ec7e53e059
Remove aInRange outparam from nsPrintJob::PrintPage. r=dholbert
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox121:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•