Get rid of no-op methods nsIDeviceContextSpec::BeginPage and EndPage
Categories
(Core :: Printing: Output, task)
Tracking
()
People
(Reporter: dholbert, Unassigned)
Details
All of the implementations of nsIDeviceContextSpec::BeginPage and ::EndPage are empty; they just immediately return NS_OK.
https://searchfox.org/mozilla-central/search?q=NS_IMETHOD+BeginPage%28%29+override&path=
https://searchfox.org/mozilla-central/search?q=NS_IMETHOD+EndPage%28%29+override&path=
Let's remove these APIs to simplify things a bit.
|
Reporter | |
Comment 1•5 years ago
•
|
||
Oh, my searchfox searches were incomplete -- I was searching for NS_IMETHOD BeginPage() override but there's one impl that's tagged as final instead of override, and it actually does something:
https://searchfox.org/mozilla-central/rev/f82d5c549f046cb64ce5602bfd894b7ae807c8f8/widget/nsDeviceContextSpecProxy.h#51
https://searchfox.org/mozilla-central/rev/f82d5c549f046cb64ce5602bfd894b7ae807c8f8/widget/nsDeviceContextSpecProxy.cpp#169
I guess it's not as obvious that this can be removed, given that implementation.
Description
•