Un-bundle reps
Categories
(DevTools :: Shared Components, task)
Tracking
(firefox83 fixed)
| Tracking | Status | |
|---|---|---|
| firefox83 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
Attachments
(22 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
Having this bundle is a pain as we have to remember to run the bundle script when we make changes to reps and people are confused where to makes changes, and we don't get benefits from it.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D93345
|
|
Assignee | |
Comment 3•4 years ago
|
||
Depends on D93347
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D93348
|
|
Assignee | |
Comment 5•4 years ago
|
||
Depends on D93351
|
|
Assignee | |
Comment 6•4 years ago
|
||
Depends on D93352
|
|
Assignee | |
Comment 7•4 years ago
|
||
Depends on D93354
|
|
Assignee | |
Comment 8•4 years ago
|
||
Depends on D93356
|
|
Assignee | |
Comment 9•4 years ago
|
||
Depends on D93358
|
|
Assignee | |
Comment 10•4 years ago
|
||
Depends on D93370
|
|
Assignee | |
Comment 11•4 years ago
|
||
Depends on D93372
|
|
Assignee | |
Comment 12•4 years ago
|
||
The file should now only impact reps, and not mention ObjectInspector or Tree.
The ObjectInspector.css file is added into jar.mn, and now import the reps
and the Tree CSS files, as it relies on those components.
Depends on D93373
|
|
Assignee | |
Comment 13•4 years ago
|
||
Depends on D93374
|
|
Assignee | |
Comment 14•4 years ago
|
||
This allows the jest tests for the shared components to be run in the devtools-node task.
For some reason, the snapshots needed to be updated (it looked like we were
missing some bits?).
Depends on D93375
|
|
Assignee | |
Comment 15•4 years ago
|
||
Depends on D93376
|
|
Assignee | |
Comment 16•4 years ago
|
||
Since the accessibility import the ObjectInspector, we need to add another
babel transformer to take care of it.
Depends on D93378
|
|
Assignee | |
Comment 17•4 years ago
|
||
For some reason the stubs needed to be updated (maybe an enzyme/jest update?)
Depends on D93389
|
|
Assignee | |
Comment 18•4 years ago
|
||
This turns all the existing reps modules into AMD modules,
so they can be loaded in the JSON Viewer without trouble.
This means we had to change the test configuration so Reps
jest test can run.
Depends on D93391
|
|
Assignee | |
Comment 19•4 years ago
|
||
XX: This is not working yet. That's the only remaining part (with Flow I guess)
Depends on D93394
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 20•4 years ago
|
||
The babel config needed to be tweaked in order to transpile the reps files.
Depends on D93395
|
|
Assignee | |
Comment 21•4 years ago
|
||
Update babel config to transpile reps files.
Depends on D93480
|
|
Assignee | |
Comment 22•4 years ago
|
||
There were some images folder, relic of an ancient time where
we needed to support the launchpad. We don't use those anymore,
so those folders are removed.
The remaining files in the tset folder weren't used, so we remove
this folder as well.
Finally, there was a redux middleware folder, containing a thunk
and a waituntilService middleware. Those 2 modules already exist
in the codebase, so we can use those from the test that were using
the reps-specific version (with little adjustments).
This marks the end of the work for this bug.
|
||
Comment 23•4 years ago
|
||
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fad6a2efebe9 [devtools] Move reps to devtools/client/shared/components/reps . r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/6191341c892d [devtools] Remove reps bundle. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/d3eb9d344742 [devtools] Remove flow annotations from reps and object inspector. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/0ff9a063bd43 [devtools] Remove devtools-reps from debugger codebase. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/dba128b8b665 [devtools] Add moz.build in devtools/client/shared/components/reps. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/17e8d4b94d6f [devtools] Update require paths to reps modules. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/50da405d30ad [devtools] Remove classnames usage in ObjectInspector components. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/21ef5b7fd153 [devtools] Fix require paths in reps folder. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/f77a0dcb7628 [devtools] Enable eslint for devtools/client/shared/components/reps. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/6bc69ff51bbd [devtools] Move Tree component to devtools/client/shared and remove devtools-components. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/fe2041ae055b [devtools] Fix loading reps from the debugger. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/9385ed137446 [devtools] Override bundled reps.css with the original one. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/0888ae6d74b3 [devtools] Update debugger bundles. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/8f61e40d5f2b [devtools] Run devtools shared components jest tests. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/77f4f300ac2b [devtools] Move reps test to the devtool/client/shared/component/test/node folder. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/98ae4cad3a73 [devtools] Fix accessibility jest test. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/c0acd949fe20 [devtools] Move object inspectors tests to devtools/client/shared/component/test/node. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/f8d43d80afee [devtools] Fix Reps support for the JSON Viewer. r=Honza. https://hg.mozilla.org/integration/autoland/rev/b460b8e64b2e [devtools] Fix debugger jest tests. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/b4d350e4db20 [devtools] Fix compatibility jest tests. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/c69a2e218dda [devtools] Fix webconsole mocha tests. r=jdescottes. https://hg.mozilla.org/integration/autoland/rev/5822afb8f110 [devtools] Remove unused/unnecessary files from the reps folder. r=jdescottes.
|
||
Comment 24•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fad6a2efebe9
https://hg.mozilla.org/mozilla-central/rev/6191341c892d
https://hg.mozilla.org/mozilla-central/rev/d3eb9d344742
https://hg.mozilla.org/mozilla-central/rev/0ff9a063bd43
https://hg.mozilla.org/mozilla-central/rev/dba128b8b665
https://hg.mozilla.org/mozilla-central/rev/17e8d4b94d6f
https://hg.mozilla.org/mozilla-central/rev/50da405d30ad
https://hg.mozilla.org/mozilla-central/rev/21ef5b7fd153
https://hg.mozilla.org/mozilla-central/rev/f77a0dcb7628
https://hg.mozilla.org/mozilla-central/rev/6bc69ff51bbd
https://hg.mozilla.org/mozilla-central/rev/fe2041ae055b
https://hg.mozilla.org/mozilla-central/rev/9385ed137446
https://hg.mozilla.org/mozilla-central/rev/0888ae6d74b3
https://hg.mozilla.org/mozilla-central/rev/8f61e40d5f2b
https://hg.mozilla.org/mozilla-central/rev/77f4f300ac2b
https://hg.mozilla.org/mozilla-central/rev/98ae4cad3a73
https://hg.mozilla.org/mozilla-central/rev/c0acd949fe20
https://hg.mozilla.org/mozilla-central/rev/f8d43d80afee
https://hg.mozilla.org/mozilla-central/rev/b460b8e64b2e
https://hg.mozilla.org/mozilla-central/rev/b4d350e4db20
https://hg.mozilla.org/mozilla-central/rev/c69a2e218dda
https://hg.mozilla.org/mozilla-central/rev/5822afb8f110
Description
•