Should use constants defined on Node, not their numerical expansion.

RESOLVED FIXED

Status

Other Applications
DOM Inspector
--
trivial
RESOLVED FIXED
16 years ago
11 years ago

People

(Reporter: Christopher Aillon (sabbatical, not receiving bugmail), Assigned: Christopher Aillon (sabbatical, not receiving bugmail))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Fix
5.31 KB, patch
glazou
: review+
Christopher Aillon (sabbatical, not receiving bugmail)
: superreview+
Details | Diff | Splinter Review
Kill all foo.nodeType == 1, etc. from inspector code.
Use foo.nodeType == Node.ELEMENT_NODE instead.
Comment on attachment 98079 [details] [diff] [review]
Fix

rs=bzbarsky
Attachment #98079 - Flags: superreview+
Comment on attachment 98079 [details] [diff] [review]
Fix

hard reviews give me headaches
r=glazman
Attachment #98079 - Flags: review+

Comment 4

16 years ago
Comment on attachment 98079 [details] [diff] [review]
Fix

a=asa (on behalf of drivers) for checkin to 1.2a
Attachment #98079 - Flags: approval+
Checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Product: Core → Other Applications
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.