[RTL] Picture-in-Picture explainer text is in reverse
Categories
(Toolkit :: Video/Audio Controls, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | verified |
People
(Reporter: itiel_yn8, Assigned: katkoor2)
References
(Blocks 2 open bugs)
Details
(Keywords: rtl)
Attachments
(4 files)
Current state
With media.videocontrols.picture-in-picture.video-toggle.mode = 2 and media.videocontrols.picture-in-picture.video-toggle.has-used = false in RTL localized builds, the PIP explainer text appears in reverse.
This should be easier to fix after bug 1666637.
Note to self:
After in bug 1666637 a .rtl class (or something similar) will be added, a .pip-explainer.rtl rule can be added somewhere around
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/media/pictureinpicture-mode-2.css with a simple direction: rtl.
|
||
Updated•4 years ago
|
|
||
Comment 4•4 years ago
|
||
|
|
||
Comment 5•4 years ago
|
||
Direction also needs fixing, as it is LTR (Nightly should appear on the left side of the paragraph)
|
||
Updated•4 years ago
|
|
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 6•3 years ago
|
||
|
||
Updated•3 years ago
|
Pushed by mhowell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/515a66b2e43c Add RTL support for PIP explainer. r=mtigley,mhowell
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
|
||
Updated•3 years ago
|
|
||
Comment 9•3 years ago
|
||
Reproduced on Nightly 83.0a1 (20201008210150) on Windows 10 from 2020-10-08.
Confirmed as fixed on 86.0b3 on Windows 10, Ubuntu 20.04 and MacOS 10.15.
Description
•