Closed Bug 1670094 Opened 3 years ago Closed 3 years ago

[RTL] Picture-in-Picture explainer text is in reverse

Categories

(Toolkit :: Video/Audio Controls, defect, P3)

Product:
Toolkit
Component:
Video/Audio Controls
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- verified

People

(Reporter: itiel_yn8, Assigned: katkoor2)

References

(Blocks 2 open bugs)

Details

(Keywords: rtl)

Attachments

(4 files)

Current state
554.24 KB, image/png
Details
How it should look like
550.75 KB, image/png
Details
image.png
3.70 KB, image/png
Details
Bug 1670094 - Add RTL support for PIP explainer. r=mtigley,mhowell
48 bytes, text/x-phabricator-request
Details | Review
Attached image Current state —

With media.videocontrols.picture-in-picture.video-toggle.mode = 2 and media.videocontrols.picture-in-picture.video-toggle.has-used = false in RTL localized builds, the PIP explainer text appears in reverse.

Attached image How it should look like —

This should be easier to fix after bug 1666637.

See Also: → 1666637

Note to self:
After in bug 1666637 a .rtl class (or something similar) will be added, a .pip-explainer.rtl rule can be added somewhere around
https://searchfox.org/mozilla-central/source/toolkit/themes/shared/media/pictureinpicture-mode-2.css with a simple direction: rtl.

Assignee: nobody → jack1391
Attached image image.png —

Direction also needs fixing, as it is LTR (Nightly should appear on the left side of the paragraph)

Assignee: jack1391 → nobody
Depends on: 1666637
Severity: -- → S2
Priority: -- → P3
Blocks: 1685549
No longer blocks: 1662870
Assignee: nobody → katkoor2
Status: NEW → ASSIGNED
Attachment #9198845 - Attachment description: Bug 1670094 - Add RTL support for PIP explainer. r=mconley → Bug 1670094 - Add RTL support for PIP explainer. r=mtigley,mhowell
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/515a66b2e43c
Add RTL support for PIP explainer. r=mtigley,mhowell

https://hg.mozilla.org/mozilla-central/rev/515a66b2e43c

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Flags: qe-verify+

Reproduced on Nightly 83.0a1 (20201008210150) on Windows 10 from 2020-10-08.
Confirmed as fixed on 86.0b3 on Windows 10, Ubuntu 20.04 and MacOS 10.15.

Status: RESOLVED → VERIFIED
status-firefox86: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.