Open Bug 1670129 Opened 3 months ago Updated 26 days ago

Updates to enterkeyhint don't take effect until the next time the text field is focused.

Categories

(Core :: DOM: Editor, defect, P3)

Firefox 83
defect

Tracking

()

People

(Reporter: rkjnsn, Assigned: m_kato)

References

(Blocks 1 open bug)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:81.0) Gecko/20100101 Firefox/81.0
Firefox for Android

Steps to reproduce:

(I discovered this bug on Firefox Android, but I'm filing here since this is where the other enterkeyhint bugs are. Let me know if I should file on Github, instead.)

  1. Visit https://jsfiddle.net/06dopzac/4/show on Firefox Nightly on Android.
  2. Tap focus the text field.
  3. Type some text.

Actual results:

The symbol on the enter key doesn't change unless one unfocuses and refocuses the text field.

Expected results:

The symbol on the enter key should change from "enter" to "send" as soon any text has been entered into the text field.

The source code of the sample can be viewed at https://jsfiddle.net/06dopzac/4.

This issue also occurs when setting mozactionhint dynamically. The sample works as expected on Chrome.

I need this functionality for an in-progress web app.

Hello, Erik thank you for this report!
https://github.com/mozilla-mobile/fenix/issues/17046

Status: UNCONFIRMED → RESOLVED
Closed: 1 month ago
Resolution: --- → MOVED

We initialize this value when taking focus. So I think that we should call SetInputContext when changing this value.

Blocks: 1648332
Status: RESOLVED → REOPENED
Component: Untriaged → DOM: UI Events & Focus Handling
Ever confirmed: true
Product: Firefox → Core
Resolution: MOVED → ---
Component: DOM: UI Events & Focus Handling → DOM: Editor
Status: REOPENED → NEW

(In reply to Makoto Kato [:m_kato] from comment #3)

We initialize this value when taking focus. So I think that we should call SetInputContext when changing this value.

It looks like the path to fix is simple enough. Can you suggest an assignee?

Severity: -- → S3
Flags: needinfo?(m_kato)
Priority: -- → P3

(In reply to Henri Sivonen (:hsivonen) (away from Bugzilla until 2021-01-11) from comment #4)

(In reply to Makoto Kato [:m_kato] from comment #3)

We initialize this value when taking focus. So I think that we should call SetInputContext when changing this value.

It looks like the path to fix is simple enough. Can you suggest an assignee?

I would like to ship this, so I handle this. But changing enterkeyhint dynamically causes that keyboard layout is changed (It means that composing text is destroyed). So this is related to https://github.com/whatwg/html/issues/4876 and I have to check iOS's implementation.

Assignee: nobody → m_kato
Flags: needinfo?(m_kato)

Safari/iOS doesn't support dynamically updating of enterkeyhint. Until resolving https://github.com/whatwg/html/issues/4876, we won't handle this...

You need to log in before you can comment on or make changes to this bug.