Closed Bug 1670286 Opened 3 years ago Closed 3 years ago

Sync vendored puppeteer to v5.5.0


(Remote Protocol :: Agent, task, P3)



(firefox85 fixed)

85 Branch
Tracking Status
firefox85 --- fixed


(Reporter: whimboo, Assigned: impossibus)


(Blocks 1 open bug)


(Whiteboard: [puppeteer-beta2-mvp])


(3 files)

Version 5.3.1 is the most recent release:

Maja, you wanted to do that. Maybe you can schedule it for next week?

Flags: needinfo?(mjzffr)
Blocks: 1651542

Maybe... it's not particularly time sensitive, but I'm sure I'll get to it eventually.

Flags: needinfo?(mjzffr)

Mark tried that for bug 1666172 here:

Maybe we could use it? When checking the diff there are tons of .md files included now. I wonder if we should not sync those?

I see an install error in that try push, so there might be some environment work to.

Summary: Sync vendored puppeteer to v5.3.x → Sync vendored puppeteer to v5.4.x
Assignee: nobody → mjzffr
Summary: Sync vendored puppeteer to v5.4.x → Sync vendored puppeteer to v5.5.0

Looks like I'll have to investigate a new crash/hang in order to complete the sync.

Also, the tests run in a completely different order when called with ./mach puppeteer-test in m-c versus npm run unit in the Puppeteer repo. DEBUG=mocha:* claims that mocha is running the tests in alpha order in both cases, but when run via mach it starts with page.spec.js. All the tests run in both cases. Perhaps this doesn't matter, but it's at least disconcerting. *shakes fist a mocha*

Does mach also call npm run unit or do we set some different options?

Bahaha, I forgot to remove a describe.only call so only the Page tests were being run. 🤦

Pushed by
[puppeteer] Remove unwanted docs directories when vendoring r=remote-protocol-reviewers,whimboo
[puppeteer] Sync vendored puppeteer to v5.5.0 r=remote-protocol-reviewers,whimboo
[remote] Update Puppeteer-vendoring documentation r=remote-protocol-reviewers,whimboo
Regressions: 1683392
You need to log in before you can comment on or make changes to this bug.