1670295 - Port Marionette:singleTap to use JSWindowActors

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P3)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

As long as we don't have touch support in our spec-compliant implementation of WebDriver Actions, we'll need this piece of "legacy actions" working in Fission.

Don't worry about testing this in chrome-scope. The only tests that depend on it use it in content only and they will eventually have to migrate to spec-compliant Actions anyway.

• layout/base/tests/marionette/test_accessiblecaret_cursor_mode.py
• layout/base/tests/marionette/test_accessiblecaret_selection_mode.py
• testing/marionette/harness/marionette_harness/tests/unit/test_accessibility.py

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I assume this should be a simple task. It's one of the last things we will have to do before being able to enable actors. Maja, will you take it?

Comment 2

[Julian Descottes [:jdescottes]]

I tried porting this, and I stumbled on the following code in listener.js:

  if (win.docShell.asyncPanZoomEnabled && legacyactions.scrolling) {
    let ev = {
      index: 0,
      type,
      id: touch.identifier,
      clientX: touch.clientX,
      clientY: touch.clientY,
      screenX: touch.screenX,
      screenY: touch.screenY,
      radiusX: touch.radiusX,
      radiusY: touch.radiusY,
      rotation: touch.rotationAngle,
      force: touch.force,
    };
    sendSyncMessage("Marionette:emitTouchEvent", ev);
    return;
  }

https://searchfox.org/mozilla-central/rev/d25eb00ab4e90cc0130cd18f303a04cc2a2f8409/testing/marionette/listener.js#332-347
I can't find any consumer for "Marionette:emitTouchEvent". It was added in Bug 958036, but all the listeners reacting to this event seem gone now, or at least I can't find them? Should we remove those if branches for now? Do nothing and log instead?

Comment 3

[Julian Descottes [:jdescottes]]

Stealing this from Maja, sorry :)

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1670295 - [marionette] Remove unused message Marionette:emitTouchEvent from listener::emitTouchEvent

The emitTouchEvent message seems no longer used.
The code branch is preserved to log a debug message instead.

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1670295 - [marionette] Port Marionette:singleTap to use JSWindowActors

Depends on D93324

This changeset duplicates some touch event helpers used by the singleTap command.
We might decide to move them to a shared module imported by listener.js and by the child window actor to avoid the duplication.

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1670295 - [marionette] Move legacy touch helpers from listener.js to legacyaction.js

Depends on D93324

Move singleTap and dependencies to legacyaction.js in order to reuse them in the JSWindowActor.

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1670295 - [marionette] Remove createATouch wrapper from listener.js

Depends on D93365

This helper does not reuse anything from the listener.js closure and can be removed safely from the touchProvider wrapper.

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1670295 - [marionette] Remove emitTouchEvent and touchProvider from listener.js

Depends on D93367
The wrapped version of emitTouchEvent only provides the current document.
But this document should always match this.container.frame.document when a dispatchActions call is happening.

Comment 9

[Chris Peterson [:cpeterson]]

Tracking marionette-fission-mvp bugs for Fission Beta milestone (M7)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/112e132aca33
[marionette] Remove unused message Marionette:emitTouchEvent from listener::emitTouchEvent r=marionette-reviewers,whimboo,maja_zf
https://hg.mozilla.org/integration/autoland/rev/a6ce536f81f5
[marionette] Move legacy touch helpers from listener.js to legacyaction.js r=marionette-reviewers,whimboo,maja_zf
https://hg.mozilla.org/integration/autoland/rev/50bb448a8f6d
[marionette] Port Marionette:singleTap to use JSWindowActors r=marionette-reviewers,whimboo,maja_zf

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/112e132aca33
https://hg.mozilla.org/mozilla-central/rev/a6ce536f81f5
https://hg.mozilla.org/mozilla-central/rev/50bb448a8f6d