Closed Bug 1670355 Opened 4 years ago Closed 4 years ago

Intermittent js\src\jit-test\tests\cacheir\add-function-prototype.js | z:\task_1602275429\src\js\src\jit-test\tests\cacheir\add-function-prototype.js:4:13 Error: Assertion failed: got false, expected true (code 3, args "--ion-eager --ion-offthread-compile

Categories

(Core :: JavaScript Engine: JIT, defect, P2)

defect

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox81 --- unaffected
firefox82 --- unaffected
firefox83 + fixed

People

(Reporter: intermittent-bug-filer, Assigned: anba)

References

(Regression)

Details

(Keywords: assertion, intermittent-failure, regression)

Attachments

(2 files)

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=318213886&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/X0nNV0QBQaOFpQMfJUtZ9g/runs/0/artifacts/public/logs/live_backing.log



[task 2020-10-09T21:33:12.893Z] TEST-PASS | js\src\jit-test\tests\cacheir\add-function-prototype.js | Success (code 0, args "") [0.3 s]
[task 2020-10-09T21:33:13.180Z] z:\task_1602275429\src\js\src\jit-test\tests\cacheir\add-function-prototype.js:4:13 Error: Assertion failed: got false, expected true
[task 2020-10-09T21:33:13.180Z] 
[task 2020-10-09T21:33:13.180Z] Stack:
[task 2020-10-09T21:33:13.180Z] 
[task 2020-10-09T21:33:13.180Z]   checkPrototype@z:\task_1602275429\src\js\src\jit-test\tests\cacheir\add-function-prototype.js:4:13
[task 2020-10-09T21:33:13.180Z] 
[task 2020-10-09T21:33:13.180Z]   addPrototype@z:\task_1602275429\src\js\src\jit-test\tests\cacheir\add-function-prototype.js:10:19
[task 2020-10-09T21:33:13.180Z] 
[task 2020-10-09T21:33:13.180Z]   test@z:\task_1602275429\src\js\src\jit-test\tests\cacheir\add-function-prototype.js:21:21
[task 2020-10-09T21:33:13.180Z] 
[task 2020-10-09T21:33:13.180Z]   @z:\task_1602275429\src\js\src\jit-test\tests\cacheir\add-function-prototype.js:55:1
[task 2020-10-09T21:33:13.180Z] 
[task 2020-10-09T21:33:13.180Z] Exit code: 3
[task 2020-10-09T21:33:13.180Z] FAIL - cacheir\add-function-prototype.js
[task 2020-10-09T21:33:13.180Z] TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\cacheir\add-function-prototype.js | z:\task_1602275429\src\js\src\jit-test\tests\cacheir\add-function-prototype.js:4:13 Error: Assertion failed: got false, expected true (code 3, args "--ion-eager --ion-offthread-compile=off --more-compartments") [0.3 s]
[task 2020-10-09T21:33:13.180Z] INFO exit-status     : 3
[task 2020-10-09T21:33:13.180Z] INFO timed-out       : False
[task 2020-10-09T21:33:13.180Z] INFO stderr         2> z:\task_1602275429\src\js\src\jit-test\tests\cacheir\add-function-prototype.js:4:13 Error: Assertion failed: got false, expected true
[task 2020-10-09T21:33:13.180Z] INFO stderr         2> Stack:
[task 2020-10-09T21:33:13.180Z] INFO stderr         2> checkPrototype@z:\task_1602275429\src\js\src\jit-test\tests\cacheir\add-function-prototype.js:4:13
[task 2020-10-09T21:33:13.180Z] INFO stderr         2> addPrototype@z:\task_1602275429\src\js\src\jit-test\tests\cacheir\add-function-prototype.js:10:19
[task 2020-10-09T21:33:13.180Z] INFO stderr         2> test@z:\task_1602275429\src\js\src\jit-test\tests\cacheir\add-function-prototype.js:21:21
[task 2020-10-09T21:33:13.180Z] INFO stderr         2> @z:\task_1602275429\src\js\src\jit-test\tests\cacheir\add-function-prototype.js:55:1```

Do you have insight what's going on here? The check fails for the arrow function () => 1. (Bug 1670323 is another Windows cgc failure which popped up at the end of last week.)

Flags: needinfo?(jdemooij)

This is a regression from bug 1666439. For GuardFunctionIsNonBuiltinCtor we need to ensure the function has both the BASESCRIPT and CONSTRUCTOR flags set, but LGuardFunctionFlags is happy if either of those flags is set. It might make sense to unify this with the IC code to prevent these issues.

Flags: needinfo?(jdemooij) → needinfo?(andrebargull)
Keywords: regression
Regressed by: 1666439
Has Regression Range: --- → yes

Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information

Priority: P5 → P2

Add comments to MGuardFunctionFlags to avoid repeating the same error in the
future.

Assignee: nobody → andrebargull
Status: NEW → ASSIGNED

Add a separate MIR node for GuardFunctionIsNonBuiltinCtor instead of trying to
reuse the existing MGuardFunctionFlags node.

Depends on D93334

Flags: needinfo?(andrebargull)
Component: JavaScript Engine → JavaScript Engine: JIT
Pushed by abutkovits@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4e0aa5559f5 Part 1: Add comments to MGuardFunctionFlags. r=jandem https://hg.mozilla.org/integration/autoland/rev/b336cb10e978 Part 2: Add a separate MIR node for GuardFunctionIsNonBuiltinCtor. r=jandem
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: