1670490 - Startup Crash in [@ mozilla::interceptor::WindowsDllDetourPatcher<T>::CreateTrampoline]

Status: RESOLVED INVALID

(Firefox :: Launcher Process, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Regression from bug 1588245 on 4+ devices - reported as 5 installations: 4 crashes on Windows 8.1, 1 on Windows 10.

[Tracking Requested - why for this release]: Regression and startup crash.

Crash report: https://crash-stats.mozilla.org/report/index/96fb4591-abf2-4655-8d31-917770201010

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(isSome())

Top 10 frames of crashing thread:

0 xul.dll mozilla::interceptor::WindowsDllDetourPatcher<mozilla::interceptor::VMSharingPolicyShared>::CreateTrampoline mozglue/misc/interceptor/PatcherDetour.h:1429
1 xul.dll mozilla::interceptor::WindowsDllDetourPatcher<mozilla::interceptor::VMSharingPolicyShared>::AddHook mozglue/misc/interceptor/PatcherDetour.h:460
2 xul.dll mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyShared>::AddDetour mozglue/misc/nsWindowsDllInterceptor.h:519
3 xul.dll mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyShared>::AddHook mozglue/misc/nsWindowsDllInterceptor.h:433
4 xul.dll static mozilla::interceptor::FuncHook<mozilla::interceptor::WindowsDllInterceptor<mozilla::interceptor::VMSharingPolicyShared>, HIMC__* mozglue/misc/nsWindowsDllInterceptor.h:200
5 ntdll.dll RtlRunOnceExecuteOnce 
6 kernelbase.dll InitOnceExecuteOnce 
7 xul.dll mozilla::plugins::BasicFunctionHook<mozilla::plugins::ID_CreateMutexW, void* dom/plugins/ipc/FunctionHook.h:183
8 xul.dll static mozilla::plugins::FunctionHook::HookFunctions dom/plugins/ipc/FunctionHook.cpp:51
9 xul.dll mozilla::plugins::PluginModuleChild::AllocPPluginInstanceChild dom/plugins/ipc/PluginModuleChild.cpp:1599

Comment 1

[Toshihito Kikuchi [:toshi]]

Sorry, it's my bad. I meant to call WindowsDllPatcherBase::SetLastError, but it was calling the WinAPI ::SetLastError. Let me quickly prepare a patch..

Comment 3

[Toshihito Kikuchi [:toshi]]

Attachment: Bug 1670490 - Rename SetLastError to SetLastDetourError to stop confusion. r=mhowell

Calling SetLastError in a lambda unintentionally called ::SetLastError
instead of WindowsDllPatcherBase::SetLastError. The fix is to rename the
function to SetLastDetourError as well as adding the this-> prefix.

Comment 7

[Toshihito Kikuchi [:toshi]]

The regressing change was backed out. This will be fixed by a newer fix on bug 1588245.

Comment 8

[Intermittent Failures Robot]

3 failures in 3694 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3

Platform breakdown:

• windows10-aarch64: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1670490&startday=2020-10-12&endday=2020-10-18&tree=all