1670510 - Do not return function that ends before the specified line in findScript

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

testcase

var g = newGlobal({newCompartment: true});
var dbg = new Debugger();
var gw = dbg.addDebuggee(g);

g.eval(`
function f() {
}
`);

gc();
gc();

let url = thisFilename();
let line = 4;

// If the specified line is the next line after the function,
// the function shouldn't match.
assertEq(dbg.findScripts({url, line}).length, 0);

GetScriptLineExtent returns 1-origin line count, and debugger uses the value as 0-origin.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1670510 - Do not return function that ends before the specified line in findScript. r?jorendorff!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe2336305997
Do not return function that ends before the specified line in findScript. r=tcampbell

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fe2336305997