1670831 - Manage Tags section fails to open if options tab was was already open with "Find in options" search results

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #1668502 +++

STR

1. Open "Options/Preferences" tab, and do a search for "update" using "Find in options". Leave options tab open with search results.
2. 3-pane, from message context menu, choose Tags > Manage Tags...

Actual result

• Options tab gets focus, but continues to show last "Find in options" search results
• Manage Tags section does not show up (not even after clearing the search)

Expected result

• "Find in options" search should be cleared
• Manage tags section should be shown

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1670831_preferences-not-opening-right-category-while-searching-0.patch

There are some test failure problems on the trunk. I have tested it locally, it's working. I will send for another try-run once the trunk is fixed.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9185438 [details] [diff] [review]
Bug-1670831_preferences-not-opening-right-category-while-searching-0.patch

Review of attachment 9185438 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks.
r=aleca

Comment 3

[Khushil Mistry [:khushil324]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=6d0d2a68940bde5082f1bfc41c8c710bb8a177c6

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/df9a40274fe5
Fix right preferences section not opening when search results are opened. r=aleca DONTBUILD

Comment 5

[Khushil Mistry [:khushil324]]

Comment on attachment 9185438 [details] [diff] [review]
Bug-1670831_preferences-not-opening-right-category-while-searching-0.patch

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Preference Tab Opening functionality will be facing a small UX problem if search operation is going on in the preference tab.
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): Low

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9185438 [details] [diff] [review]
Bug-1670831_preferences-not-opening-right-category-while-searching-0.patch

[Triage Comment]
Approved for esr78 - no beta, but has tests and low risk.
We don't plan another beta for uplifts - so this will appear in beta 84

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/bc8fb1598ed3