1670851 - Extensions are Not Exempt from Font Selections

Status: RESOLVED FIXED

(WebExtensions :: Developer Outreach, enhancement)

Description

[john-ivan]

Attachment: BrokenAddon.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Overrode Fonts to protect my eyes.

Actual results:

It made uBlock icons invisible and hard to find and click.

Expected results:

The settings should not have broken an addon.

Comment 1

[Raluca Popovici, Desktop QA]

Hi,
I cannot reproduce this issue on my machine Ubuntu 18x64 with Firefox Release 81.0.2, Firefox Beta 82.0b9 and Nightly 83.0a1 (2020-10-18) (64-bit).
Can you please download Firefox Nightly from here: https://nightly.mozilla.org/ and retest the problem and see if the issue still occurs there as well?
Does this issue occur with a fresh profile? you can find the steps here : https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager
Please help us with some more detailed steps to reproduce(such as the font used) so we can confirm it.

Comment 2

[john-ivan]

General->Colors: Text:Orange, Background:Black, "Override the colors...":Always

This applies to all add-ons.

Debian 10 Stable, Firefox ESR 78.3.0, from repository

Comment 3

[Tomislav Jovanovic :zombie]

Hey Raymond, can you please check this out?

Comment 4

[[e-mail]]

uBO's icons in the popup panel are not font-based, they are SVG-based. To change the color of these, one needs to override the fill property -- and I am assuming the color setting from "Fonts and Colours" in Firefox overrides only the color property?

Comment 5

[john-ivan]

This problem could be avoided by websites and extensions by putting outlines around images so they don't disappear with a similarly colored background color.

This problem could be avoided by Firefox by making the transparent parts of images the color of the original webpage(or the CSS default if the site does not specify since that is what most designers expect) instead of the override color.

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: ublock-overridden-colors-on-light-theme.png

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: ublock-overridden-colors-on-dark-theme.png

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

I've double-checked the current behavior under the scenario described in comment 0 on more recent Firefox versions and the icons from the uBlock browserAction popup seems to be now:

• white colored when the Firefox theme selected is the dark one (see screenshot attached to comment 7)
• and instead of the same color as the screenshot attached to comment 0 when the Firefox theme selected is the light one (see screenshot attached to comment 6)

In the screenshot from comment 0 instead it looks like the Firefox theme selected was the dark one but the browserAction popup the ones that are now used only when the selected Firefox theme is the light one.

On that side the behavior seems to have improved in the more recent version of Firefox (or more recent version of the extension, or not unlikely a combination of both).

While I was looking into the behavior around this use case, I took that as a chance to look what would be the behavior for the extensions that are using the browser_style manifest property (which is not the case for ublock, but it is for some other extensions, e.g. multi-accounts-container) and filed Bug 1873024.

I'm going to close this bug as fixed, but feel free to needinfo me if the behavior experienced is not the one described in this comment and may be worth taking another look.