1670892 - migrate AOL users to OAuth2 to deal with AOL/Yahoo password login shutdown (DL October 20, 2020)

Status: RESOLVED FIXED

(Thunderbird :: Security, task, P1)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1606339 +++

From bug 1606339, AOL users will also be affected by the normal password login shutdown. (AOL and Yahoo have the same parent company.)

We should migrate them to OAuth2 as well.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1670892_migrate_aol.patch

Migrate AOL as well.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9181247 [details] [diff] [review]
bug1670892_migrate_aol.patch

Review of attachment 9181247 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks for taking care of this.
Just a couple of super tiny nits in the comments.

::: mail/base/modules/MailMigrator.jsm
@@ +535,5 @@
>    /* eslint-enable complexity */
>  
>    /**
> +   * Migrate incoming server to using OAuth2 as authMethod.
> +   * @param {string} hostnameHint - What the hostname should end with.

nit: empty comment row before the @param, just to respect the JSDoc format

@@ +551,5 @@
> +  },
> +
> +  /**
> +   * Migrate outgoing server to using OAuth2 as authMethod.
> +   * @param {string} hostnameHint - What the hostname should end with.

nit: same here

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/84a3703a3875
migrate AOL users to OAuth2 to deal with AOL/Yahoo password login shutdown (DL October 20, 2020). r=aleca

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9181247 [details] [diff] [review]
bug1670892_migrate_aol.patch

[Approval Request Comment]
User impact if declined: some AOL users cut off from their mail access
Testing completed (on c-c, etc.): just landed
Risk to taking this patch (and alternatives if risky): it's reusing what we had implemented for yahoo. There's always some risk of unforeseen problems.

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9181247 [details] [diff] [review]
bug1670892_migrate_aol.patch

[Triage Comment]
approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 82.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/6395bad1e97a

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9181247 [details] [diff] [review]
bug1670892_migrate_aol.patch

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.4.0:
https://hg.mozilla.org/releases/comm-esr78/rev/9a85300e0420