1670917 - Update libcubeb to revision a7e83aa (and associated repos/crates)

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, task)

Description

[Paul Adenot (:padenot)]

This contains commits:
a7e83aa - Add stream_set_name = null to cubeb_ops structs (#617)
7c9a666 - oss: Initialize cubeb_stream::state properly (#618)
226d383 - OSS (FreeBSD/illumos) backend (#600)
dce06b1 - Add stream preference to request a persistent stream session and implement this in WASAPI.
8d596fe - Address review comments
3fbbc67 - Don't use AUDCLNT_STREAMOPTIONS_RAW on MinGW, it's not defined yet.
b33659d - Make RAW WASAPI streams opt-in
2141a1e - Pass in AUDCLNT_STREAMOPTIONS_RAW when possible when initializing an AudioClient
970e118 - Require at least the windows 8.1 SDK for building cubeb
01e0997 - Add stream_set_name = null to cubeb_ops structs
2e842a0 - Add method to change stream name
082ba33 - Fix CMake rust path and only use rust deps if needed
1d480fa - jack: Add functions to connect a cb+phys port pair
dafe69a - jack: Special case playing mono source in stereo

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1670917 - Add the new OSS backend for cubeb to update.sh. r?#cubeb-reviewers

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1670917 - Update libcubeb to a7e83aa. r?#cubeb-reviewers

Depends on D93360

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1670917 - Upstream build system and other bits from freebsd-ports. r?#cubeb-reviewers

This is the first two chunks in https://github.com/freebsd/freebsd-ports/blob/ed3dd5591642608f136a452c9e1d1b765721d498/www/firefox/files/patch-cubeb-oss, from From: jbeich <[e-mail]>. The rest of this patch file is now upstream.

This allows OSS users to drop a patch downstream.

Depends on D93361

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1670917 - Add a pref to allow using raw WASAPI streams. Make it default to input-only raw streams. r?kinetik

Depends on D93339

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1670917 - Update audioipc to revision c474b0b. r?#cubeb-reviewers

Depends on D93363

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1670917 - Update cubeb-related crates to match the new cubeb ABI. r?#cubeb-reviewers

Depends on D93364

Comment 7

[Paul Adenot (:padenot)]

Attachment: Bug 1670917 - mach vendor rust. r?#cubeb-reviewers

Depends on D93366

Comment 8

[Jan Beich]

Comment on attachment 9181304 [details]
Bug 1670917 - Add the new OSS backend for cubeb to update.sh. r?#cubeb-reviewers

Can you update to a7e83aa in order to pick up one more OSS fix? See https://github.com/kinetiknz/cubeb/compare/7c9a666...a7e83aa. Without it cubeb_stream_set_name on FreeBSD may crash Firefox.

EDIT: Oops, this comment is against attachment 9181305 [details] instead.

Comment 9

[Paul Adenot (:padenot)]

I meant to do that but failed, thanks for double-checking.

Comment 10

[Paul Adenot (:padenot)]

Looks like another bug (bug 1615884, that I was fixing at the same time on the same machine) had reformatted cubeb to something else and it was completely different from upstream as well, so I fixed this in the same update.

Comment 11

[Paul Adenot (:padenot)]

This needs https://github.com/djg/cubeb-pulse-rs/pull/63 to be merged before landing.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/426aa6482835
Add the new OSS backend for cubeb to update.sh. r=cubeb-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/6ad13b34f08d
Update libcubeb to a7e83aa. r=cubeb-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/b58d65b96f2d
Upstream build system and other bits from freebsd-ports. r=cubeb-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/0285b2ab6d50
Add a pref to allow using raw WASAPI streams. Make it default to input-only raw streams. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/881fac72e13c
Update audioipc to revision c474b0b. r=cubeb-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/b0825300e78d
Update cubeb-related crates to match the new cubeb ABI. r=cubeb-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/635942af8244
mach vendor rust. r=cubeb-reviewers,chunmin

Comment 13

[Razvan Maries]

Backed out for perma failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=84a5f3d3858c24cc49262f7479a119475287a0dc&searchStr=gtest&selectedTaskRun=DUF7Jrj8Ta-PS35f83tFDA.0

Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319169195&repo=autoland&lineNumber=28937
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319166370&repo=autoland&lineNumber=28723
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319163961&repo=autoland&lineNumber=29427
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319166028&repo=autoland&lineNumber=28717
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319166229&repo=autoland&lineNumber=29386
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319169211&repo=autoland&lineNumber=29430

Backout: https://hg.mozilla.org/integration/autoland/rev/696fe5816935b3be77afc521fc67e8aa291eddea

Comment 14

[Matthew Gregan [:kinetik]]

Attachment: Bug 1670917 - Update cubeb_ops layout in MockCubeb. r?#cubeb-reviewers

Comment 15

[Matthew Gregan [:kinetik]]

D94202 should fix this - green GTest linux1804-64-asan (and others) with fix applied.

Comment 16

[Paul Adenot (:padenot)]

Thanks, Matthew, I'll reland this as is with your patch on top.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a315d159c710
Add the new OSS backend for cubeb to update.sh. r=cubeb-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/c43e96393162
Update libcubeb to a7e83aa. r=cubeb-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/05f488a3248c
Upstream build system and other bits from freebsd-ports. r=cubeb-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/7aabab2aec48
Add a pref to allow using raw WASAPI streams. Make it default to input-only raw streams. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/c5f44f282feb
Update audioipc to revision c474b0b. r=cubeb-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/ea18293a465f
Update cubeb-related crates to match the new cubeb ABI. r=cubeb-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/7947997fb69a
mach vendor rust. r=cubeb-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/c5dd23d6bdd8
Update cubeb_ops layout in MockCubeb.  r=cubeb-reviewers,padenot

Comment 18

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a315d159c710
https://hg.mozilla.org/mozilla-central/rev/c43e96393162
https://hg.mozilla.org/mozilla-central/rev/05f488a3248c
https://hg.mozilla.org/mozilla-central/rev/7aabab2aec48
https://hg.mozilla.org/mozilla-central/rev/c5f44f282feb
https://hg.mozilla.org/mozilla-central/rev/ea18293a465f
https://hg.mozilla.org/mozilla-central/rev/7947997fb69a
https://hg.mozilla.org/mozilla-central/rev/c5dd23d6bdd8