1670997 - |mach ide vscode| removes existing settings

Status: NEW

(Developer Infrastructure :: Developer Environment Integration, defect, P3)

Description

[Sid Vishnoi :sidvishnoi]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

1. Run mach ide vscode
2. Accept "Configuration for vscode/settings.json must change" prompt.

Actual results:

The command removed existing configuration in settings.json.
This happens because the .vscode/settings.json is non-standard JSON (it supports comments and trailing commas), so the default json module in Python doesn't take them into account, leading to an exception at https://searchfox.org/mozilla-central/rev/803b368879fa332e8e2c1840bf1ec164f7ed2c32/python/mozbuild/mozbuild/backend/mach_commands.py#240-242

Expected results:

Existing options should've persisted.

At minimum, the exception should be logged to inform user that their settings will be overwritten, and not just edited.
Nicer would be to use a json library that supports vscode's settings.json.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1670997 - Correctly handle artifact builds when running 'mach ide vscode'. r?andi!

Comment 2

[Phabricator Automation]

Comment on attachment 9327407 [details]
Bug 1670997 - Correctly handle artifact builds when running 'mach ide vscode'. r?andi!

Revision D174909 was moved to bug 1683626. Setting attachment 9327407 [details] to obsolete.