printing broken again on trunk - Print dialog come up but will not send output to printer
Categories
(Thunderbird :: General, defect, P1)
Tracking
(thunderbird_esr78 unaffected, thunderbird83+ fixed)
Tracking | Status | |
---|---|---|
thunderbird_esr78 | --- | unaffected |
thunderbird83 | + | fixed |
People
(Reporter: paul, Assigned: rnons)
References
Details
(Keywords: regression)
Attachments
(1 file)
4.48 KB,
patch
|
mkmelin
:
review+
wsmwk
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36
Steps to reproduce:
this is related to 2020-10-12 83.01a version
alt-f / p
print dialouge comes up ok
Actual results:
click print no output
Expected results:
output should have printed
note backgraded to 2020-10-08 all working ok
Comment 1•4 years ago
|
||
Confirmed (no output for Print to file)
Comment 2•4 years ago
|
||
Comment 3•4 years ago
|
||
I see this in the console now:
Uncaught TypeError: can't access property "outerWindowId", aBrowsingContext.currentWindowGlobal is undefined
printWindow chrome://global/content/printUtils.js:306
startPrintWindow chrome://global/content/printUtils.js:293
getContentWindowOrOpenURI chrome://messenger/content/mailWindow.js:754
createContentWindow chrome://messenger/content/mailWindow.js:708
Comment 4•4 years ago
|
||
Print preview doesn't work either
Uncaught TypeError: can't access property "getSourceBrowser", aListenerObj is undefined
printPreview chrome://global/content/printUtils.js:409
observe chrome://messenger/content/msgPrintEngine.js:86
printUtils.js:409:7
Comment 5•4 years ago
|
||
Ping, can you look at this ASAP?
Assignee | ||
Comment 6•4 years ago
|
||
Bug 1669925 added an extra argument to printPreview
and startPrintWindow
for telemetry purpose. This patch ports it to c-c, sadly this only fixes printing. Print preview crashes with no error message now, will investigate more.
Assignee | ||
Updated•4 years ago
|
Comment 7•4 years ago
|
||
Comment 8•4 years ago
|
||
We'll need this for beta.
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9a615b3306e5
Port bug 1669925: Fix printing. r=mkmelin
Comment 10•4 years ago
|
||
Comment on attachment 9182536 [details] [diff] [review]
1671131.patch
[Approval Request Comment]
Regression caused by (bug #): bug 1669925
User impact if declined: can't print
Testing completed (on c-c, etc.): landed on comm-central
Risk to taking this patch (and alternatives if risky): not much risk as printing is completely broken without it
Comment 11•4 years ago
|
||
Assignee | ||
Comment 12•4 years ago
|
||
Sorry, I also missed a few changes to printWindow
, will send a patch soon.
Assignee | ||
Comment 13•4 years ago
|
||
(In reply to Ping Chen (:rnons) from comment #12)
Sorry, I also missed a few changes to
printWindow
, will send a patch soon.
Never mind, it was startPrintWindow
changed, no missing. However, print in viewSource window doesn't work, don't know why.
Comment 14•4 years ago
|
||
Comment on attachment 9182536 [details] [diff] [review]
1671131.patch
[Triage Comment]
Approved for beta
Comment 15•4 years ago
|
||
bugherder uplift |
Description
•