Closed Bug 1671163 Opened 6 months ago Closed 6 months ago

Move object-inspector outside of the reps folder

Categories

(DevTools :: Shared Components, task)

task

Tracking

(firefox84 fixed)

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: nchevobbe, Assigned: seunbayo83, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

After Bug 1669956 lands, the folder structure of reps will be the following:

devtools/client/shared/components/reps
|_ reps
|_ object-inspector

which means that some require calls that only care about reps modules can end up like devtools/client/shared/components/reps/reps/rep , which is non-optimal

There's no added value for the object inspector to be inside reps, so we should move it out of it, and put everything from the devtools/client/shared/components/reps/reps/ folder into devtools/client/shared/components/reps/

I am interested in working on this.

Can i get more explanation?

Flags: needinfo?(nchevobbe)

Hello Seun!

Sure you can :)

So we have this folder https://searchfox.org/mozilla-central/source/devtools/client/shared/components/reps/object-inspector that we would want to move so it's directly at devtools/client/shared/components/object-inspector instead.

You should be able to move the folder using hg mv devtools/client/shared/components/reps/object-inspector devtools/client/shared/components/object-inspector

Then, you need to update the moz.build files (remove the reference we have here: https://searchfox.org/mozilla-central/source/devtools/client/shared/components/reps/moz.build#8 , and add a reference here: https://searchfox.org/mozilla-central/rev/61728de8273c04fe2417c475fc0637e8b79210d7/devtools/client/shared/components/moz.build#7-14)

And finally, we need to update all the places where we reference the old path: https://searchfox.org/mozilla-central/search?q=devtools%2Fclient%2Fshared%2Fcomponents%2Freps%2Fobject-inspector&path=&case=true&regexp=false


If it's your first bug, you might want to read this https://firefox-source-docs.mozilla.org/devtools/getting-started/README.html to setup the work environment.
Make sure to select "Artifact builds" when asked as it speeds up the workflow quite a bit :)

I'm assigning the bug to you, don't hesitate to ask any question :)

Assignee: nobody → seunbayo83
Status: NEW → ASSIGNED
Flags: needinfo?(nchevobbe)

i am pulling again from repo to see the mistake i made,apologies for the delay

Attachment #9183442 - Attachment description: Bug 1671163 - moved object inspector out of reps folder and update all Path. r?nchevobbe → Bug 1671163 - [devtools] Move object inspector out of reps folder. r=nchevobbe
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b13fc7fd2bb8
[devtools] Move object inspector out of reps folder. r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Blocks: 1675497
You need to log in before you can comment on or make changes to this bug.