Closed Bug 1671171 Opened 1 year ago Closed 3 months ago

DevTools Performance tab - spacing polish

Categories

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P3)

enhancement

Tracking

(firefox93 fixed)

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: julienw, Assigned: jdescottes, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Attached image image.png

This is copied over from https://github.com/firefox-devtools/profiler/issues/2640.

From victoria:

We should have less top spacing when DevTools is short. For the Accessibility welcome panel (in stable only) the semi-responsive way we did this was padding-top: 15vh;. For the Performance tab I might suggest

.perf-devtools .perf-button-container {
    margin-top: 10vh;
}

When DevTools is docked to side, we should have padding of 10vh on each side. Also, we can have the 'Settings' label be on its own line. Open the attachment to see how this could look:

Mentor: jwajsberg

Care to explain more please?

Depends on D100588

Assignee: nobody → kaeyosthaeron
Status: NEW → ASSIGNED

Would be nice to fix this before enabling on release channel.
Julien, can you take a look at the review request?

Blocks: 1693316
Flags: needinfo?(jwajsberg)

I will, thanks for the reminder!

Flags: needinfo?(jwajsberg)
Flags: needinfo?(jdescottes)

Hi kaeyosthaeron and sorry for the delay!

I requested a few changes on the patch.
Considering it is 8 months old, I want to check if you are still interested in finishing this work.

Let us know!

Flags: needinfo?(jdescottes) → needinfo?(kaeyosthaeron)

No answer, will assume we can pick it up from here.

Flags: needinfo?(kaeyosthaeron)
Assignee: kaeyosthaeron → jdescottes
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2733988278a2
[devtools] Improve vertical layout display for new performance panel r=julienw

Thanks for working on this, Julian :D

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in before you can comment on or make changes to this bug.