1671193 - jit_test.py might need to better support the --enable-webrender flag

Status: RESOLVED FIXED

(Testing :: General, task)

Description

[Kartikaya Gupta (email:[e-mail])]

Windows64 ccov builds on central run jittests, and they pass fine. When run with webrender enabled, this happens:

[task 2020-10-09T21:57:17.136Z] 21:57:17     INFO - Calling ['C:\\Users\\task_1602279933\\build\\venv\\Scripts\\python', '-u', 'C:\\Users\\task_1602279933\\build\\tests\\jit-test\\jit-test\\jit_test.py', '--total-chunks', '8', '--this-chunk', '2', '--enable-webrender', '--setpref=layers.d3d11.enable-blacklist=false', 'tests/bin/js', '--no-slow', '--no-progress', '--format=automation', '--jitflags=all', '--timeout=970'] with output_timeout 1000
[task 2020-10-09T21:57:17.540Z] 21:57:17     INFO -  No tests found matching command line arguments.
[task 2020-10-09T21:57:17.611Z] 21:57:17     INFO - Return code: 0
[task 2020-10-09T21:57:17.611Z] 21:57:17    ERROR - No tests run or test summary not found

So maybe the --enable-webrender command line flag is messing up the command line parsing or something, and no tests get matched.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Here's the equivalent line from a passing m-c log:

[task 2020-10-14T13:53:22.619Z] 13:53:22     INFO - Calling ['C:\\Users\\task_1602678008\\build\\venv\\Scripts\\python', '-u', 'C:\\Users\\task_1602678008\\build\\tests\\jit-test\\jit-test\\jit_test.py', '--total-chunks', '8', '--this-chunk', '1', 'tests/bin/js', '--no-slow', '--no-progress', '--format=automation', '--jitflags=all', '--timeout=970'] with output_timeout 1000

Comment 2

[Kartikaya Gupta (email:[e-mail])]

jit_test.py has --enable-webrender support, but I don't see --setpref support, so maybe that's what's tripping it up.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Probably needs to be added here: https://searchfox.org/mozilla-central/rev/803b368879fa332e8e2c1840bf1ec164f7ed2c32/taskcluster/taskgraph/transforms/tests.py#1634-1637

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1671193 - Don't try to set prefs in jittests as it doesn't work. r?jrmuizel

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/756e35501b70
Don't try to set prefs in jittests as it doesn't work. r=jrmuizel

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/756e35501b70