1671205 - Return moz:debuggerAddress in capabilities when Remote Agent is active

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Marionette should return the debugger address (host and port of the remote protocol web server) as part of the capabilities. That way we will not have to scrape the stderr output with geckodriver (bug 1669218).

As best we should add the host and port properties on the Remote Agent component, which can then be read by Marionette.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Actually the return host:port combination is not the websocket but the address of the HTTP server. As such the capability should be named identically.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1671205 - [marionette] Return moz:debuggerAddress in capabilities when Remote Agent is active.

Depends on D96009

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1900289bdac
[marionette] Return moz:debuggerAddress in capabilities when Remote Agent is active. r=marionette-reviewers,jdescottes,maja_zf

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_capabilities.js

backout: https://hg.mozilla.org/integration/autoland/rev/f9beb63cb0d1e12985fa7fef150ef23989bd0aae

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=a1900289bdac31b543a5d4e46cbd7aae22599a0e&selectedTaskRun=C4vhPXVNTwej65sUXR-gcg.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=320981818&repo=autoland&lineNumber=1983

[task 2020-11-06T18:22:17.019Z] 18:22:17 INFO - TEST-START | testing/marionette/test/unit/test_capabilities.js
[task 2020-11-06T18:22:17.447Z] 18:22:17 WARNING - TEST-UNEXPECTED-FAIL | testing/marionette/test/unit/test_capabilities.js | xpcshell return code: 0
[task 2020-11-06T18:22:17.448Z] 18:22:17 INFO - TEST-INFO took 428ms
[task 2020-11-06T18:22:17.448Z] 18:22:17 INFO - >>>>>>>
[task 2020-11-06T18:22:17.448Z] 18:22:17 INFO - testing/marionette/test/unit/test_capabilities.js | xpcw: cd /data/local/tmp/test_root/xpc/testing/marionette/test/unit
[task 2020-11-06T18:22:17.450Z] 18:22:17 INFO - testing/marionette/test/unit/test_capabilities.js | xpcw: xpcshell --greomni /data/local/tmp/test_root/xpcb/geckoview-androidTest.apk -m -e const _HEAD_JS_PATH = "/data/local/tmp/test_root/xpc/head.js"; -e const _MOZINFO_JS_PATH = "/data/local/tmp/test_root/xpc/p/mozinfo.json"; -e const _PREFS_FILE = "/data/local/tmp/test_root/xpc/user.js"; -e const _TESTING_MODULES_DIR = "/data/local/tmp/test_root/xpc/m"; -f /data/local/tmp/test_root/xpc/head.js -e const _HEAD_FILES = []; -e const _JSDEBUGGER_PORT = 0; -e const _TEST_FILE = ["test_capabilities.js"]; -e const _TEST_NAME = "testing/marionette/test/unit/test_capabilities.js"; -e _execute_test(); quit(0);
[task 2020-11-06T18:22:17.450Z] 18:22:17 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-11-06T18:22:17.450Z] 18:22:17 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2020-11-06T18:22:17.451Z] 18:22:17 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2020-11-06T18:22:17.451Z] 18:22:17 INFO - running event loop
[task 2020-11-06T18:22:17.451Z] 18:22:17 INFO - testing/marionette/test/unit/test_capabilities.js | Starting test_Timeouts_ctor
[task 2020-11-06T18:22:17.451Z] 18:22:17 INFO - (xpcshell/head.js) | test test_Timeouts_ctor pending (2)
[task 2020-11-06T18:22:17.452Z] 18:22:17 INFO - TEST-PASS | testing/marionette/test/unit/test_capabilities.js | test_Timeouts_ctor - [test_Timeouts_ctor : 29] 0 == 0

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The patch has been updated and once re-reviewed will be landed again.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2e729917288
[marionette] Return moz:debuggerAddress in capabilities when Remote Agent is active. r=marionette-reviewers,jdescottes,maja_zf

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b2e729917288