1671217 - MobileViewportManager never sets mIsFirstPaint to false when in VisualViewportOnly mode

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task)

Description

[Kartikaya Gupta (email:[e-mail])]

Here is where MobileViewportManager::mIsFirstPaint gets set to false, but that never runs on desktop because of this early exit.

This is more of a perf problem than a correctness problem, AFAICT. It means we end up doing a bunch of work that we don't need to.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Easy to fix, but sadly makes writing a test for bug 1669982 harder because we won't call UpdateDisplayPortMargins as much.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=0dcbd18d9b1b186940f5ea66c2795628f5b172d9

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1671217 - Ensure we clear mIsFirstPaint in the visual-viewport-only MVM case. r?tnikkel

There should be no user-visible correctness change here, just doing less
unnecessary work.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1671217 - Ensure we clear mIsFirstPaint in the visual-viewport-only MVM case. r?tnikkel

There should be no user-visible correctness change here, just doing less
unnecessary work.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/950fb95c5769
Ensure we clear mIsFirstPaint in the visual-viewport-only MVM case. r=tnikkel

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/950fb95c5769