1671241 - Set aria-activedescendant upon selecting a tab-to-search result if the user's previous action wasn't typing

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Harry Twyford]

Following the work in bug 1647929, we don't set aria-activedescendant to tab-to-search results when the user presses tab to select them. This is because the result is announced to screen readers when the user is typing and we don't want to announce it twice. However, Marco pointed out in this review comment that we don't handle the edge case where the user Tabs through all the results and eventually ends up back at the tab-to-search result. Or if the user passes the tab-to-search result then Shift+Tabs back up to it. We should set aria-activedescendant in these cases, since we didn't recently announce the result to the user.

Comment 1

[Marco Bonardo [:mak]]

Or we could set/unset something when the selection moves off from the tab to search result.

Comment 2

[Harry Twyford]

Attachment: Bug 1671241 - Set aria-activedescendant upon selecting a tab-to-search result if the user previously selected the tab-to-search result. r?mak!

Comment 3

[Harry Twyford]

https://treeherder.mozilla.org/jobs?repo=try&revision=e1f89ed55d3c39b01125113006f6ac605c2415b8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41a57cf51420
Set aria-activedescendant upon selecting a tab-to-search result if the user previously selected the tab-to-search result. r=mak

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/41a57cf51420