Closed Bug 1671274 Opened 4 years ago Closed 4 years ago

SearchSettings.jsm and SearchService.jsm import OS.File during startup

Categories

(Toolkit Graveyard :: OS.File, task)

Tracking

(firefox89 fixed)

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: emmamalysz, Assigned: masterwayz, Mentored)

References

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

We should remove the instances of OS.File from SearchSettings.jsm and use their IOUtils equivalents: https://searchfox.org/mozilla-central/rev/9c72508fcf2bba709a5b5b9eae9da35e0c707baa/toolkit/components/search/SearchSettings.jsm#13,99-100,103,215,217

No longer depends on: 1649601
Depends on: 1671035
Depends on: 1674311
Assignee: nobody → michael
Status: NEW → ASSIGNED
Depends on: 1649601
No longer depends on: 1649601

I spoke wiith :masterwayz, and we are going to cover both removals in this bug now.

Depends on: 1649601
Summary: SearchSettings.jsm imports OS.File during startup → SearchSettings.jsm and SearchService.jsm import OS.File during startup
Attachment #9188122 - Attachment description: Bug 1671274 - Convert SearchSettings.jsm to use IOUtils instead of OS.File r=emalysz → WIP: Bug 1671274 - Convert SearchSettings.jsm and SearchService.jsm to no longer use OS.File r=emalysz
Attachment #9188122 - Attachment description: WIP: Bug 1671274 - Convert SearchSettings.jsm and SearchService.jsm to no longer use OS.File r=emalysz → Bug 1671274 - Convert SearchSettings.jsm and SearchService.jsm to no longer use OS.File r=emalysz
Pushed by michelle@masterwayz.nl: https://hg.mozilla.org/integration/autoland/rev/6b0908a8b7de Convert SearchSettings.jsm and SearchService.jsm to no longer use OS.File r=barret
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Regressions: 1758014
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: