1671369 - Migrate error handling to CACHE_TRY

Status: RESOLVED FIXED

(Core :: Storage: Cache API, task)

Description

[Simon Giesecke [:sg] [he/him]]

Migrate error handling to CACHE_TRY in https://searchfox.org/mozilla-central/rev/9c72508fcf2bba709a5b5b9eae9da35e0c707baa/dom/cache/QuotaClient.cpp#379 and functions called from there.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Use CACHE_TRY in CacheQuotaClient::GetUsageForOriginInternal. r=#dom-workers-and-storage

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Move CloneFileAndAppend to QuotaCommon. r=#dom-workers-and-storage

Depends on D93662

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Change LockedGetPaddingSizeFromDB to return a Result. r=#dom-workers-and-storage

Depends on D93765

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Move anonymous namespace inside mozilla::dom::cache. r=#dom-workers-and-storage

Depends on D93766

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Change GetBodyUsage to return a Result. r=#dom-workers-and-storage

Depends on D93767

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Extract ReduceUsageInfo function from GetBodyUsage and GetUsageForOriginInternal. r=#dom-workers-and-storage

Depends on D93769

Comment 7

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Extract ReduceEach function from ReduceUsageInfo. r=#dom-workers-and-storage

Depends on D93771

Comment 8

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Change OpenDBConnection to return a Result. r=#dom-workers-and-storage

Depends on D93772

Comment 9

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Change LockedDirectoryPaddingRestore to return a Result and use CACHE_TRY. r=#dom-workers-and-storage

Depends on D93773

Comment 10

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Change LockedDirectoryPaddingGet to return a Result and use CACHE_TRY. r=#dom-workers-and-storage

Depends on D93774

Comment 11

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Change DirectoryPaddingFileExists to use CACHE_TRY. r=#dom-workers-and-storage

Depends on D93775

Comment 12

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Change GetUsageForClient to return a UsageInfo. r=#dom-workers-and-storage

Depends on D93776

Comment 13

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671369 - Change QM_NewLocalFile to use QM_TRY. r=#dom-workers-and-storage

Depends on D93777

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/988f10b132a7
Move CloneFileAndAppend to QuotaCommon. r=dom-workers-and-storage-reviewers,janv

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/988f10b132a7

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dce0143fd57f
Use CACHE_TRY in CacheQuotaClient::GetUsageForOriginInternal. r=ttung
https://hg.mozilla.org/integration/autoland/rev/766cd2f7e4c9
Change LockedGetPaddingSizeFromDB to return a Result. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/455a0080b317
Move anonymous namespace inside mozilla::dom::cache. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/41c717fa78a6
Change GetBodyUsage to return a Result. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/d1d8b7135769
Extract ReduceUsageInfo function from GetBodyUsage and GetUsageForOriginInternal. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/52a8b3761a96
Extract ReduceEach function from ReduceUsageInfo. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/1d8e631f3ef5
Change OpenDBConnection to return a Result. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/38831a147235
Change LockedDirectoryPaddingRestore to return a Result and use CACHE_TRY. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/f6955fdfa8fb
Change LockedDirectoryPaddingGet to return a Result and use CACHE_TRY. r=dom-workers-and-storage-reviewers,ttung

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd52cc7d250f
Change DirectoryPaddingFileExists to use CACHE_TRY. r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/4ab4b6e6ce86
Change QM_NewLocalFile to use QM_TRY. r=dom-workers-and-storage-reviewers,ttung

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/868577854548
Change GetUsageForClient to return a UsageInfo. r=dom-workers-and-storage-reviewers,ttung

Comment 19

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/dce0143fd57f
https://hg.mozilla.org/mozilla-central/rev/766cd2f7e4c9
https://hg.mozilla.org/mozilla-central/rev/455a0080b317
https://hg.mozilla.org/mozilla-central/rev/41c717fa78a6
https://hg.mozilla.org/mozilla-central/rev/d1d8b7135769
https://hg.mozilla.org/mozilla-central/rev/52a8b3761a96
https://hg.mozilla.org/mozilla-central/rev/1d8e631f3ef5
https://hg.mozilla.org/mozilla-central/rev/38831a147235
https://hg.mozilla.org/mozilla-central/rev/f6955fdfa8fb
https://hg.mozilla.org/mozilla-central/rev/bd52cc7d250f
https://hg.mozilla.org/mozilla-central/rev/4ab4b6e6ce86
https://hg.mozilla.org/mozilla-central/rev/868577854548