Closed Bug 1671457 Opened 4 years ago Closed 3 years ago

[Inactive CSS] Incorrect warning for text-overflow: ellipsis

Categories

(DevTools :: Inspector: Rules, defect, P2)

defect

Tracking

(firefox87 fixed)

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: rcaliman, Assigned: sebo)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

Steps to reproduce:

  • Run the following in the address bar of a new tab:
data:text/html,<style>div {width: 4ch; overflow-x: hidden; text-overflow: ellipsis}</style><div>Overflow
  • Open DevTools, Inspect the <div>
  • In the Rules view, notice the text-overflow property

Expected result
No Inactive CSS warning because text-overflow: ellipsis does apply in this scenario and works correctly.

Actual result
There is an Inactive CSS warning next to the text-overflow: ellipsis CSS declaration which incorrectly states that it does not apply since overflow: hidden is missing. But there is overflow control, it's just using the longhand version, overflow-x.

For reference, try this sample:

data:text/html,<style>div {width: 4ch; overflow: hidden; text-overflow: ellipsis}</style><div>Overflow
Severity: -- → S3
Priority: -- → P2

In order to be able to reuse the check for whether a note has a vertical writing mode, the logic got split out from the table track parent method into its own method.

Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED

Corrected the warning about when text-overflow has no effect including different settings for overflow-x and overflow-y depending on the writing mode.

Depends on D102814

Attachment #9198768 - Attachment description: Bug 1671457 - Put vertical writiing mode check into separate method r=jdescottes → Bug 1671457 - Put vertical writing mode check into separate method r=jdescottes
Pushed by sebastianzartner@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/39b791bc82f4
Put vertical writing mode check into separate method r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/a7568d8de2b1
Fixed incorrect inactive CSS warning for text-overflow r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch

This might be worth mentioning in the release notes for 87 together with the change in bug 1551571.

Sebastian

Keywords: dev-doc-needed
QA Whiteboard: [qa-87b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: