1671457 - [Inactive CSS] Incorrect warning for text-overflow: ellipsis

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Razvan Caliman [:rcaliman]]

Attachment: CSS warning for text-oveflow

Steps to reproduce:

• Run the following in the address bar of a new tab:

data:text/html,<style>div {width: 4ch; overflow-x: hidden; text-overflow: ellipsis}</style><div>Overflow

• Open DevTools, Inspect the <div>
• In the Rules view, notice the text-overflow property

Expected result
No Inactive CSS warning because text-overflow: ellipsis does apply in this scenario and works correctly.

Actual result
There is an Inactive CSS warning next to the text-overflow: ellipsis CSS declaration which incorrectly states that it does not apply since overflow: hidden is missing. But there is overflow control, it's just using the longhand version, overflow-x.

For reference, try this sample:

data:text/html,<style>div {width: 4ch; overflow: hidden; text-overflow: ellipsis}</style><div>Overflow

Comment 2

[Sebastian Zartner [:sebo]]

Attachment: Bug 1671457 - Put vertical writing mode check into separate method r=jdescottes

In order to be able to reuse the check for whether a note has a vertical writing mode, the logic got split out from the table track parent method into its own method.

Comment 3

[Sebastian Zartner [:sebo]]

Attachment: Bug 1671457 - Fixed incorrect inactive CSS warning for text-overflow r=jdescottes

Corrected the warning about when text-overflow has no effect including different settings for overflow-x and overflow-y depending on the writing mode.

Depends on D102814

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39b791bc82f4
Put vertical writing mode check into separate method r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/a7568d8de2b1
Fixed incorrect inactive CSS warning for text-overflow r=jdescottes

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/39b791bc82f4
https://hg.mozilla.org/mozilla-central/rev/a7568d8de2b1

Comment 6

[Sebastian Zartner [:sebo]]

This might be worth mentioning in the release notes for 87 together with the change in bug 1551571.

Sebastian

Comment 7

[Chris Mills [:cmills]]

Documentation done; see https://github.com/mdn/content/issues/2505