1671578 - Implement GeckoSession.Loader.equals()

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

In AC we have a bunch of tests that verify that we forward the correct data to GeckoView.

A simplified example is:

engineSession.loadUrl("http://mozilla.org")

verify(geckoSession).loadUri(
    "http://mozilla.org",
    null as GeckoSession?,
    GeckoSession.LOAD_FLAGS_NONE,
    null as Map<String, String>?
)

If I translate this to using GeckoSession.Loader:

 verify(geckoSession).load(
    GeckoSession.Loader()
        .uri("https://www.mozilla.org")
)

... then this fails because since GeckoSession.Loader doesn't implement equals it falls back to comparing references. Implementing equals() (and then probably also hashCode()) would help us write test and would make GeckoSession.Loader more like a data class in Kotlin or a Record in Java 14+.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Since all fields are private I also can't work around this by capturing the arguments and comparing myself.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1671578 - Overload Loader.equals.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55a5da81f312
Overload Loader.equals. r=snorp

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59fd9fd259e0
Backed out changeset 55a5da81f312 for linting opt failures.
https://hg.mozilla.org/integration/autoland/rev/f20537ff856c
Overload Loader.equals.

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f20537ff856c