Closed Bug 1671587 Opened 4 years ago Closed 4 years ago

Perma browser/components/migration/tests/unit/test_Chrome_bookmarks.js | test_Chrome - [test_Chrome : 148] Should only get a 'From BrowserX' folder when the 2h2020 pref is disabled - false == true when Gecko 83 merges to Late Beta on 2020-10-30

Categories

(Firefox :: Migration, defect)

defect

Tracking

()

VERIFIED FIXED
84 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox81 --- unaffected
firefox82 --- unaffected
firefox83 + fixed
firefox84 --- verified

People

(Reporter: aryx, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

central-as-late-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedTaskRun=AfQUI-WxS4SYX8iU4bvXEA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=ce16ec38108ccab129136851e0ca53f9f3a3f1d4
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=318821912&repo=try

[task 2020-10-16T11:38:49.673Z] 11:38:49 INFO - TEST-PASS | browser/components/migration/tests/unit/test_Chrome_bookmarks.js | test_Chrome - [test_Chrome : 147] Should have seen 10 folders. - 10 == 10
[task 2020-10-16T11:38:49.674Z] 11:38:49 WARNING - TEST-UNEXPECTED-FAIL | browser/components/migration/tests/unit/test_Chrome_bookmarks.js | test_Chrome - [test_Chrome : 148] Should only get a 'From BrowserX' folder when the 2h2020 pref is disabled - false == true
[task 2020-10-16T11:38:49.674Z] 11:38:49 INFO - /builds/worker/workspace/build/tests/xpcshell/tests/browser/components/migration/tests/unit/test_Chrome_bookmarks.js:testBookmarks:148
[task 2020-10-16T11:38:49.674Z] 11:38:49 INFO - /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:248
[task 2020-10-16T11:38:49.674Z] 11:38:49 INFO - /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:577
[task 2020-10-16T11:38:49.675Z] 11:38:49 INFO - -e:null:1

Flags: needinfo?(jaws)
See Also: → 1671952
Assignee: nobody → gijskruitbosch+bugs
Attachment #9182439 - Attachment description: Bug 1671587 - fix perma-fail of test_Chrome_bookmarks.js when the 2020h2 pref gets flipped, jaws → Bug 1671587 - fix perma-fail of test_Chrome_bookmarks.js when the 2020h2 pref gets flipped, r?jaws
Status: NEW → ASSIGNED

Comment on attachment 9182439 [details]
Bug 1671587 - fix perma-fail of test_Chrome_bookmarks.js when the 2020h2 pref gets flipped, r?jaws

Beta/Release Uplift Approval Request

  • User impact if declined: test fix
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): test-only change

(required for bug 1671952)

  • String changes made/needed: no
Attachment #9182439 - Flags: approval-mozilla-beta?

Comment on attachment 9182439 [details]
Bug 1671587 - fix perma-fail of test_Chrome_bookmarks.js when the 2020h2 pref gets flipped, r?jaws

Approved for b1

Attachment #9182439 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fae3f4f6271b
fix perma-fail of test_Chrome_bookmarks.js when the 2020h2 pref gets flipped, r=jaws
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Regressions: 1606125
Flags: needinfo?(jaws)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: