Closed Bug 1671598 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26128 - [AspectRatio] Fix divide by zero with a small float ratio

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26128 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26128
Details from upstream follow.

b'Christian Biesinger <cbiesinger@chromium.org>' wrote:

[AspectRatio] Fix divide by zero with a small float ratio

A small float number will convert to a zero layout unit, leading to a
division by zero.

R=ikilpatrick@chromium.org, mstensho@chromium.org

Fixed: 1137262, 1137264, 1137471, 1137227
Change-Id: Iea57ab61369570f08e74384a763e6ec4f2fa155e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475453
Commit-Queue: Christian Biesinger \<cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817454}

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3bb47375402
[wpt PR 26128] - [AspectRatio] Fix divide by zero with a small float ratio, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.