Closed Bug 1671606 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26137 - Reenable scroll-animations/element-based-offset tests

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox84 fixed)

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26137 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26137
Details from upstream follow.

b'Kevin Ellis <kevers@chromium.org>' wrote:

Reenable scroll-animations/element-based-offset tests

The underlying source of the test flakes was likely addressed in
recent changes to the handling of play and pause for scroll-linked
animations.

https://chromium-review.googlesource.com/c/chromium/src/+/2386339

This patch also contains a cleanup to remove the unnecessarily
convoluted way of hiding the scrollbar for the clamped offset test.

Tested with 1000+ retries of the two tests in a virtual threaded
environment.

Bug: 1080609
Change-Id: If9097b0a2017a9c87a359b61ba93f35bae56b512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475935
Reviewed-by: Xida Chen \<xidachen@chromium.org>
Commit-Queue: Kevin Ellis \<kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817568}

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
FAIL: 8

Chrome

OK : 1
PASS: 8

Safari

OK : 1
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/scroll-animations/element-based-offset-clamp.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Animation start and current times are correct given
element-based offsets for orienation vertical and no clamping is expected.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation vertical and start is visible at zero offset and should get clamped.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation vertical and end is not reachable and should be clamped.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation vertical and both start and end are clamped.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation horizontal and no clamping is expected.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation horizontal and start is visible at zero offset and should get clamped.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation horizontal and end is not reachable and should be clamped.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation horizontal and both start and end are clamped.: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/scroll-animations/element-based-offset-clamp.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f93888cc787
[wpt PR 26137] - Reenable scroll-animations/element-based-offset tests, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.