1671668 - Search mode chiclet colors don't match dark theme

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Danny Colin [:sdk]]

Attachment: tabtosearch.jpg

STR

0. Focus the AwesomeBar
1. Type a search engine keyword
2. Press Tab to autocomplete the suggested search engine

Actual Behavior

The search engine keyword is changed to a pill that contain the search engine title but the pill use bright colors that fits more with the Light theme.

Expected Behavior

Pill colors should follow the dark theme colorscheme

Comment 1

[Harry Twyford]

We're going to invert the colours on the chiclet when in dark mode.

[Tracking Requested - why for this release]:
UI issue with a new feature launching in 83. The fix will be CSS-only, making it low risk for uplift.

Comment 2

[Harry Twyford]

Attachment: Bug 1671668 - Invert the colors in the search mode indicator in dark mode. r?adw,ntim

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dc0cfd11b22
Invert the colors in the search mode indicator in dark mode. r=adw,ntim

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5dc0cfd11b22

Comment 5

[Harry Twyford]

Comment on attachment 9184367 [details]
Bug 1671668 - Invert the colors in the search mode indicator in dark mode. r?adw,ntim

Beta/Release Uplift Approval Request

• User impact if declined: Dark mode colors will look wrong in new feature launching in 83.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only.
• String changes made/needed:

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9184367 [details]
Bug 1671668 - Invert the colors in the search mode indicator in dark mode. r?adw,ntim

Low risk, approved for 83 beta 6, thanks.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/99e696023271

Comment 8

[Pablo]

Replicated the issue on Firefox Nightly 83.0a1 dated 10/14

Verified fix on Windows10 64bit , Ubuntu 20 64bit , and MacOS 10.14
Using: Latest Firefox Nightly 84.0a1 + Firefox Beta 83.0b6

the color of the "dark mode" search shortcut container is dark blue.