Closed
Bug 1671695
Opened 4 years ago
Closed 4 years ago
--with-system-icu fails to build: error: undefined hidden symbol
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
84 Branch
People
(Reporter: matias, Assigned: dminor)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
701 bytes,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
After bug 1669573 was merged, building with system ICU started to fail with "error: undefined hidden symbol" for the following symbols:
icu_67::Calendar::createInstance(icu_67::TimeZone*, icu_67::Locale const&, UErrorCode&)
icu_67::Calendar::setTimeInMillis(double, UErrorCode&)
icu_67::DateFormatSymbols::createForLocale(icu_67::Locale const&, UErrorCode&)
icu_67::DateFormatSymbols::~DateFormatSymbols()
icu_67::UMemory::operator delete(void*)
icu_67::Calendar::get(UCalendarDateFields, UErrorCode&) const
icu_67::DateFormatSymbols::getMonths(int&, icu_67::DateFormatSymbols::DtContextType, icu_67::DateFormatSymbols::DtWidthType) const
icu_67::DateFormatSymbols::getWeekdays(int&, icu_67::DateFormatSymbols::DtContextType, icu_67::DateFormatSymbols::DtWidthType) const
Applying the attached patch fixes the issue.
Updated•4 years ago
|
Has Regression Range: --- → yes
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Assignee: nobody → dminor
Assignee | ||
Comment 2•4 years ago
|
||
Thank you for the patch and sorry about the inconvenience!
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 3•4 years ago
|
||
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/89873d4afb47 Fix system icu build; r=zbraniecki
Comment 5•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Assignee | ||
Comment 6•4 years ago
|
||
Comment on attachment 9182118 [details]
Bug 1671695 - Fix system icu build; r=zbraniecki!
Beta/Release Uplift Approval Request
- User impact if declined: Build is broken for users who build with system ICU library.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Low risk, this only affects build configuration.
- String changes made/needed: None
Attachment #9182118 -
Flags: approval-mozilla-beta?
Comment 7•4 years ago
|
||
Comment on attachment 9182118 [details]
Bug 1671695 - Fix system icu build; r=zbraniecki!
Approved for 83 beta 3, thanks.
Attachment #9182118 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•4 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•