1671695 - --with-system-icu fails to build: error: undefined hidden symbol

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[matias]

Attachment: Patch to fix the issue

After bug 1669573 was merged, building with system ICU started to fail with "error: undefined hidden symbol" for the following symbols:

• icu_67::Calendar::createInstance(icu_67::TimeZone*, icu_67::Locale const&, UErrorCode&)
• icu_67::Calendar::setTimeInMillis(double, UErrorCode&)
• icu_67::DateFormatSymbols::createForLocale(icu_67::Locale const&, UErrorCode&)
• icu_67::DateFormatSymbols::~DateFormatSymbols()
• icu_67::UMemory::operator delete(void*)
• icu_67::Calendar::get(UCalendarDateFields, UErrorCode&) const
• icu_67::DateFormatSymbols::getMonths(int&, icu_67::DateFormatSymbols::DtContextType, icu_67::DateFormatSymbols::DtWidthType) const
• icu_67::DateFormatSymbols::getWeekdays(int&, icu_67::DateFormatSymbols::DtContextType, icu_67::DateFormatSymbols::DtWidthType) const

Applying the attached patch fixes the issue.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1671695 - Fix system icu build; r=zbraniecki!

Comment 2

[Dan Minor [:dminor]]

Thank you for the patch and sorry about the inconvenience!

Comment 3

[Dan Minor [:dminor]]

Try run here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5553dfa17896dd769d4aa00566fe6b920c5f56b9

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89873d4afb47
Fix system icu build; r=zbraniecki

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/89873d4afb47

Comment 6

[Dan Minor [:dminor]]

Comment on attachment 9182118 [details]
Bug 1671695 - Fix system icu build; r=zbraniecki!

Beta/Release Uplift Approval Request

• User impact if declined: Build is broken for users who build with system ICU library.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk, this only affects build configuration.
• String changes made/needed: None

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9182118 [details]
Bug 1671695 - Fix system icu build; r=zbraniecki!

Approved for 83 beta 3, thanks.

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/61b9efdc4019