1671697 - Crash in [@ nsDocShell::InternalLoad]

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[u608768]

Crash report: https://crash-stats.mozilla.org/report/index/9f5cbb25-72be-43e9-9905-f8f420201015

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(false) (NS_SUCCEEDED(mBrowsingContext->SetHistoryID(historyID)))

Top 10 frames of crashing thread:

0 XUL nsDocShell::InternalLoad docshell/base/nsDocShell.cpp:9341
1 XUL nsDocShell::LoadHistoryEntry docshell/base/nsDocShell.cpp:11725
2 XUL nsDocShell::LoadHistoryEntry docshell/base/nsDocShell.cpp:11649
3 XUL nsDocShell::Reload docshell/base/nsDocShell.cpp:4034
4 XUL mozilla::dom::Location::Reload dom/base/Location.cpp:583
5 XUL mozilla::dom::Location_Binding::reload dom/bindings/LocationBinding.cpp:1143
6 XUL bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::MaybeCrossOriginObjectThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3229
7 XUL js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:598
8 XUL Interpret js/src/vm/Interpreter.cpp:3335
9 XUL js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:635

Line was last touched in bug 1666326, but we have a number of crashes from before then.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

I can't see how that assertion could be right. We run scripts in the method before that line is executed, so the browsing context could very well be going away.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1671697 - Crash in [@ nsDocShell::InternalLoad], r=peterv

Comment 3

[janet [:janet]]

dropping the severity to be more closely aligned with the description of S1 being a catastrophic dot release driver. Please update if I got this wrong.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f24964c3a231
Crash in [@ nsDocShell::InternalLoad], r=peterv

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f24964c3a231

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta uplift?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Yes.
Sorry, was on vacation. Is it too late for beta?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Yes