Closed Bug 1671707 Opened 4 years ago Closed 4 years ago

Calls to nsIPrinter.createDefaultSettings() are incorrect in the frontend code

Categories

(Core :: Printing: Setup, enhancement, P3)

Product:
Core
Component:
Printing: Setup
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: alaskanemily, Assigned: alaskanemily)

Details

(Whiteboard: [print2020_v84][old-ui-])

Attachments

(1 file)

Bug 1671707 - Remove extra argument from createDefaultSettings calls
47 bytes, text/x-phabricator-request
Details | Review

Both the mocking interface and the print preview setup have a "name" argument, but the native implementation does not have this extra argument. It also seems unused in all cases.

Whiteboard: [print2020_v84][old-ui-]
Pushed by emcdonough@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04eb885e22ce
Remove extra argument from createDefaultSettings calls r=sfoster

https://hg.mozilla.org/mozilla-central/rev/04eb885e22ce

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: