1671720 - Crash in [@ TestHTTPAnswerRunnable::OnStartRequest]

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Crash report: https://crash-stats.mozilla.org/report/index/58408700-168a-4e63-924b-97e920201014

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll TestHTTPAnswerRunnable::OnStartRequest dom/security/nsHTTPSOnlyUtils.cpp:437
1 xul.dll mozilla::extensions::ChannelWrapper::RequestListener::OnStartRequest toolkit/components/extensions/webrequest/ChannelWrapper.cpp:1073
2 xul.dll nsJARChannel::OnStartRequest modules/libjar/nsJARChannel.cpp:999
3 xul.dll nsInputStreamPump::OnInputStreamReady netwerk/base/nsInputStreamPump.cpp:390
4 xul.dll nsInputStreamReadyEvent::Run xpcom/io/nsStreamUtils.cpp:94
5 xul.dll mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal xpcom/threads/TaskController.cpp:515
6 xul.dll mozilla::detail::RunnableFunction<`lambda at /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:88:7'>::Run xpcom/threads/nsThreadUtils.h:577
7 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1197
8 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:109
9 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:327

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1671720: HTTPS-Only Mode: Query if channel is auth only if we can query nsIHttpChannelInternal. r=dragana

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eeb566e9aee6
HTTPS-Only Mode: Query if channel is auth only if we can query nsIHttpChannelInternal. r=dragana

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:ckerschb, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/eeb566e9aee6

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ckerschb, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #5)

The patch landed in nightly and beta is affected.
:ckerschb, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

Oh, I thought we landed in time for 83, must have been right at the cut-off then. I'll file the uplift request.

Comment 7

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 9182281 [details]
Bug 1671720: HTTPS-Only Mode: Query if channel is auth only if we can query nsIHttpChannelInternal. r=dragana

Beta/Release Uplift Approval Request

• User impact if declined: User opting into using HTTPS-Only Mode in about:preferences might experience that crash.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We are effectively adding a Nullcheck on the variable that was a nullptr.
• String changes made/needed: no

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9182281 [details]
Bug 1671720: HTTPS-Only Mode: Query if channel is auth only if we can query nsIHttpChannelInternal. r=dragana

Crash fix, safe patch, approved for 83 beta 84, thanks.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/167bd6435d96