1671764 - Don't select random en-* dictionary when lang attribute is en, not en-US

Status: RESOLVED FIXED

(Core :: Spelling checker, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

From https://searchfox.org/mozilla-central/rev/40b561b9accbff54387edcba2b8b4a3c3828110e/editor/spellchecker/tests/test_bug1200533.html#126-127

When using <textarea lang="en">, our spell checker selects random en dictionary even if system or application is en-US locale. So if en-GB dictionary is installed in Firefox, we might select en-GB dictionary on lang=en even if Firefox is en-US package. I think we should select en-US dictionary in this situation.

So we should respect application locale and system locale for order of spellchecker.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1671764 - Part 1. Use ACString for dictionary language instead.

Actually, our locale service doesn't use UTF-16 for locale name and it will
be ASCII. Although dictionary name of spell checker is locale/language name,
it still uses UTF-16. To use locale API, I should replace it with ACString.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1671764 - Part 2. Respect application/system locale if language code is matched.

When we don't match exactly dictionary name with lang attribute, we look for
language name. When looking for language name (ex. en/fr etc), we don't
consider the priority by application/system locale. So if lang=en, it may be
selected by character order. Most case is that en-GB is always selected if it
is installed.

We should respect application/system locale if language name is matched to
current content language before random selection.

Depends on D99336

Comment 3

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/jobs?repo=try&revision=882bddeab20b9956a529b312fd9de9e2b0e4adfc

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40144f211b5d
Part 1. Use ACString for dictionary language instead. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/221fabfedacb
Part 2. Respect application/system locale if language code is matched. r=masayuki

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/40144f211b5d
https://hg.mozilla.org/mozilla-central/rev/221fabfedacb