1671839 - [Fission] Fix and re-enable back.py and navigate.py for Fission

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

At least locally these tests seem to pass now.
But they do fail in non-Fission occasionally too, so need to check how tryserver behaves.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a2f6f9d469572ba0ab0510a67c5cc5f94b0f237

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1671839 - [Fission] Enable back.py and navigate.py in Fission, r=peterv

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13e30b1593e6
[Fission] Enable back.py and navigate.py in Fission, r=peterv

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset 13e30b1593e6 (Bug 1671839) for causing webdriver failures in element_click/navigate.py

Backout link: https://hg.mozilla.org/integration/autoland/rev/2a1f496849fdf86e98b7ce42767fb39944403ac0

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&tochange=2a1f496849fdf86e98b7ce42767fb39944403ac0&fromchange=66c4d6a8aa86615859ed222e60c7600c7c0aa3cc&searchStr=wd

Failure logs:

• back.py: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319005321&repo=autoland&lineNumber=28205
• navigate.py: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=319005493&repo=autoland&lineNumber=78750

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

uh.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=270aeab450172ed13fecef9fba6c0207827adae9

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1671839 - Fix and re-enable back.py and navigate.py for Fission

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a393513f134318b3c18b79c4d2fc6e5eb5a33985

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/jobs?repo=try&revision=3662979063458f64d293e9e4219c945a7c11fd0f
WD looks good on that

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

running more tests
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d42e9c839528ab8e1089f07b7ef370c92854db13

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1671839 - [Fission] Fix and re-enable back.py and navigate.py for Fission, r=peterv

I think there could be still other issues with persist handling (or at least it could be simplified),
but this should be pretty much the minimal patch to fix the issue when
about:newtab url is changed to about:blank (without a redirect, but magical about: handling).
So we need to check persisted handling later than currently.

I'd prefer to land something like this first and then consider if there are better ways to handle
both about: url changes and proper redirects.

Depends on D93899

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c1799b04689
[Fission] Enable back.py and navigate.py in Fission, r=peterv,webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/ec5dd48ae304
[Fission] Fix and re-enable back.py and navigate.py for Fission, r=peterv

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8c1799b04689
https://hg.mozilla.org/mozilla-central/rev/ec5dd48ae304