1671897 - Improve QM_ASSERT_UNREACHABLE*

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task)

Description

[Simon Giesecke [:sg] [he/him]]

Define QM_ASSERT_UNREACHABLE and QM_ASSERT_UNREACHABLE_VOID only in DEBUG builds to avoid misues, and add analogous QM_DIAGNOSTIC_ASSERT_UNREACHABLE and QM_DIAGNOSTIC_ASSERT_UNREACHABLE_VOID for diagnostic builds.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671897 - Add QM_DIAGNOSTIC_ASSERT_UNREACHABLE and define QM_*_ASSERT_UNREACHABLE only when the assert level is active. r=#dom-workers-and-storage

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2a1d34fe1f2
Add QM_DIAGNOSTIC_ASSERT_UNREACHABLE and define QM_*_ASSERT_UNREACHABLE only when the assert level is active. r=dom-workers-and-storage-reviewers,janv

Comment 3

[Atila Butkovits]

Backed out for causing bustage on TestQuotaCommon.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1956745be8f4582c9dfd6c0c02cadbf3e175bd54

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=d2a1d34fe1f2c7e92bc20a4101af8bbbcdf9d767&searchStr=build&selectedTaskRun=Ujugz_0nQG-CPlocgJNYcA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=318995428&repo=autoland&lineNumber=14112

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f6b239b9c97
Add QM_DIAGNOSTIC_ASSERT_UNREACHABLE and define QM_*_ASSERT_UNREACHABLE only when the assert level is active. r=dom-workers-and-storage-reviewers,janv

Comment 5

[Simon Giesecke [:sg] [he/him]]

Fixed opt builds and relanded.

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1671897 - Fix test naming. r=janv,#dom-workers-and-storage

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d0729e690dc
Fix test naming. r=janv,dom-workers-and-storage-reviewers

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9f6b239b9c97
https://hg.mozilla.org/mozilla-central/rev/1d0729e690dc