1671943 - Create home content section ui

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Erica Wright [:ewright]]

Attachment: Screen Shot 2020-10-19 at 10.50.26 AM.png

In the customize component we should be able to toggle components of the new tab page on and off. This bug will focus on the UI portion of that. Attached image of the card components.

Comment 1

[Erica Wright [:ewright]]

Attachment: Bug 1671943 - Create home content section for customize menu.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bae008440598
Create home content section for customize menu. r=prathiksha,thecount,fluent-reviewers,flod

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing node test failures in CustomizeMenu.scss

Backout link: https://hg.mozilla.org/integration/autoland/rev/c6a6ac66e5c67253e52e7be6facd89d8e1d1209f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=VwMZBngmRDyuTwuXF5Gnvw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=bae0084405986ede6bebdc77a239eaa48c22b2a6

Failure log: https://treeherder.mozilla.org/logviewer?job_id=324039075&repo=autoland&lineNumber=512

TEST START | checkBundles
[task 2020-12-09T12:39:11.890Z] TEST START | karma
[task 2020-12-09T12:40:07.914Z] TEST START | sasslint
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(5, 1): Space expected between blocks (empty-line-between-blocks)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(51, 23): Color functions such as 'rgba' should only be used in variable declarations (no-color-literals)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(68, 12): Trailing semicolons required (trailing-semicolon)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(89, 6): No trailing whitespace allowed (no-trailing-whitespace)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(91, 1): Space expected between blocks (empty-line-between-blocks)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(105, 5): ID selectors not allowed (no-ids)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(106, 5): ID selectors not allowed (no-ids)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(111, 25): Color functions such as 'rgba' should only be used in variable declarations (no-color-literals)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(118, 5): ID selectors not allowed (no-ids)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(119, 5): ID selectors not allowed (no-ids)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(122, 23): Strings must use single quotes (quotes)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(127, 5): ID selectors not allowed (no-ids)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(127, 46): No trailing whitespace allowed (no-trailing-whitespace)
[task 2020-12-09T12:40:09.005Z] TEST-UNEXPECTED-FAIL sasslint | content-src/components/CustomizeMenu/_CustomizeMenu.scss(128, 5): ID selectors not allowed (no-ids)

Comment 4

[Natalia Csoregi [:nataliaCs]]

Also failing: https://treeherder.mozilla.org/logviewer?job_id=324043987&repo=autoland&lineNumber=3080

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98e6f69f3c79
Create home content section for customize menu. r=prathiksha,thecount,fluent-reviewers,flod

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 98e6f69f3c79 (bug 1671943) for bc failures at browser_parsable_css.js.

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=5ee2649eac6153f5b4349c1d3621357892917a3a&selectedTaskRun=YMM2e3ZbTCuzwYM0_lTszw.0

https://treeherder.mozilla.org/jobs?repo=autoland&fromchange=955341cf5839dffdf849c2b750c75e22b9b5f7d0&searchStr=windows%2C10%2Cx64%2Copt%2Cmochitests%2Ctest-windows10-64%2Fopt-mochitest-browser-chrome-e10s%2Cbc7&tochange=73c14ef5fc52efac77b9608e689e0dc92112d8f1&selectedTaskRun=YMM2e3ZbTCuzwYM0_lTszw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=324070689&repo=autoland&lineNumber=3949

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8b7642c497f
Backed out changeset 98e6f69f3c79 for bc failures at browser_parsable_css.js. CLOSED TREE

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/64154055a1e4
Backed out changeset 98e6f69f3c79 for bc failures at browser_parsable_css.js. CLOSED TREE

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91a298ce72d7
Create home content section for customize menu. r=prathiksha,thecount,fluent-reviewers,flod

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/91a298ce72d7

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement and I can confirm that the "Shortcuts", "Recommended by Pocket", "Recent activity", "Snippets", and "Manage more settings" elements are displayed in the "customize component" according to the specs from here.

Verified using the latest Firefox Nightly (85.0a1 Build ID - 20201211093444) installed on Windows 10 x64, Mac 10.15, and Linux Mint 20 x64.